[Bug 9070] New: Searching for authority from tag editor for field 650 gives error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Priority: P5 - low Change sponsored?: --- Bug ID: 9070 Assignee: gmcharlt@gmail.com Summary: Searching for authority from tag editor for field 650 gives error Severity: normal Classification: Unclassified OS: All Reporter: magnus@enger.priv.no Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha Searching for autorities in "Home › Authorities" works fine but doing the same search in the tag editor for the 650 field (marc21) gives this error: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. Here's the URL of the page showing the error: http://example.com:8080/cgi-bin/koha/authorities/auth_finder.pl?op=do_search&type=intranet&index=tag_650_subfield_a_214074_10477&authtypecode=TOPIC_TERM&marclist=mainmainentry&and_or=and&operator=contains&value_mainstr=Common+Cold+&marclist=mainentry&and_or=and&operator=contains&marclist=any&and_or=and&operator=contains&marclist=match&and_or=and&operator=contains&orderby=HeadingAsc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13438&action=edit Bug 9070: authority searches in auth_finder error out GetAuthType returns a hash and not a reference to a hash. When you try to treat a regular hash like a reference, as is the case in auth_finder when using authority records imported into Koha from elsewhere, bad things happen. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13438|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 13439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13439&action=edit Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out GetAuthType returns a hash and not a reference to a hash. When you try to treat a regular hash like a reference, as is the case in auth_finder when using authority records imported into Koha from elsewhere, bad things happen. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13439|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13440&action=edit Bug 9070: authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13440|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 13441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13441&action=edit Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. No warning about "defined(%hash) is deprecated" under perl v5.10.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : * passes koha-qa.pl * works as advertised * no string changes passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13441|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13553&action=edit Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. No warning about "defined(%hash) is deprecated" under perl v5.10.1. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9070 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- This patch is in 3.10.x and 3.8.x (was in 3.10.0 release will be 3.8.8) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org