[Bug 19040] New: Refactor C4::Biblio::GetMarcBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Bug ID: 19040 Summary: Refactor C4::Biblio::GetMarcBiblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org Because adding parameters to pass to called subroutines is difficult, change parameters to be a hashref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14385 Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65531&action=edit Bug 19040: Refactor GetMarcBiblio parameters Change parameters to a hashref. Test plan to come later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65695&action=edit Bug 19040: print STDERRs to develop test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- TEST PLAN --------- perldoc C4::Biblio prove t/Biblio.t prove t/db_dependent/Acquisition/OrderFromSubscription.t prove t/db_dependent/AdditionalField.t prove t/db_dependent/Bookseller.t prove t/db_dependent/Letters.t prove t/db_dependent/Serials/Claims.t prove t/db_dependent/Serials_2.t prove t/db_dependent/Authorities/Merge.t prove t/db_dependent/Biblio.t prove t/db_dependent/Exporter/Record.t prove t/db_dependent/Record/marcrecord2csv.t prove t/db_dependent/HoldsQueue.t prove t/db_dependent/Items.t prove t/db_dependent/Koha/Filter/EmbedItemsAvailability.t prove t/db_dependent/OAI/Sets.t prove t/db_dependent/Koha/BiblioUtils.t prove t/db_dependent/OAI/Server.t prove t/db_dependent/Reserves/MultiplePerRecord.t prove t/db_dependent/ShelfBrowser.t run the koha qa test tools -- if the changes have a typo, they'll fail. eyeball each change: - have the parameters changed? That is, should biblionumber, embeditems, and opac be the same expected values as before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65695|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 65695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65695 Bug 19040: print STDERRs to develop test plan Not needed to push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65531|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 66101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66101&action=edit Bug 19040: Refactor GetMarcBiblio parameters Change parameters to a hashref. Rebased: 2017-08-16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66101|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66145&action=edit [SIGNED-OFF] Bug 19040: Refactor GetMarcBiblio parameters Change parameters to a hashref. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refactor |Change prototype of |C4::Biblio::GetMarcBiblio |C4::Biblio::GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66145|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66457&action=edit Bug 19040: Refactor GetMarcBiblio parameters Change parameters to a hashref. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good to me. Two calls in migration_tools/22_to_30 still in old style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66458&action=edit Bug 19040: [QA Follow-up] Adjust embed_items parameter in showdiffmarc Trivial adjustment Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- carp 'GetMarcBiblio called without parameters'; Should be a Koha::Exception. See coding guidelines. git grep -E "GetMarcBiblio\s*\(\s*\$" No results as expected git grep -E "GetMarcBiblio\s*\(\s*[^{]" misc/migration_tools/22_to_30/missing090field.pl: my $record = GetMarcBiblio($biblionumber); misc/migration_tools/22_to_30/rebuild_unimarc_100.pl: my $record = GetMarcBiblio($biblionumber); [OK] t/Biblio.t:warning_is { $ret = GetMarcBiblio() } Who is going to run these scripts still? And from what version? Should we still have in master ?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #9)
Who is going to run these scripts still? And from what version? Should we still have in master ??
People upgrading from Koha 2.2? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66477&action=edit Bug 19040: Update 2 occurrences of GetMarcBiblio in 22_to_30 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Marcel de Rooy from comment #9)
Who is going to run these scripts still? And from what version? Should we still have in master ??
People upgrading from Koha 2.2?
People upgrading from 2.2 to current are likely to stop at 3.4 before proceeding to master due to items being stored differently, at least that was my impression. That's why I didn't change those two scripts. But I suppose it can't hurt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
(In reply to Marcel de Rooy from comment #9)
Who is going to run these scripts still? And from what version? Should we still have in master ??
People upgrading from Koha 2.2?
Sure? :) My impression was that you would call 22_to_30 from 3.0. So we should not be needing them in master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Then let's remove them :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18927 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org