[Bug 20998] New: Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Bug ID: 20998 Summary: Non superlibrarians cannot search for patrons using the quicksearch at the top Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76453&action=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |barton@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76453|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76455&action=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76456&action=edit Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17829 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity, that's clearly critical for installations with IndependentBranches. I have added a follow-up to simplify the conditional statement. Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76455|0 |1 is obsolete| | Attachment #76456|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76466&action=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76467&action=edit Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76466|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 76517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76517&action=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76467|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 76518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76518&action=edit Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #10 from Barton Chittenden <barton@bywatersolutions.com> --- Request for back-port (issue first occurs in 17.11, I believe) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate, | |rel_18_05_candidate | Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 17829 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org