[Bug 34079] New: The phrase "Displaying [all|approved|pending|rejected] terms" was separated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Bug ID: 34079 Summary: The phrase "Displaying [all|approved|pending|rejected] terms" was separated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The phrase "Displaying [all|approved|pending|rejected] terms" was cut into individual words by bug 30733. However, in French, we need to be able to change the sentence structure (it would become something like "Displaying terms [all|approved|pending|rejected]"). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 152523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152523&action=edit Bug 34079 - The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Tricky indeed. In my opinion, we should use the all phrase to have context and no %s : <h4> [% IF ( filter_approved_all ) %]<span>Displaying all terms</span>[% END %] [% IF ( filter_approved_ok ) %]<span>Displaying approved terms</span>[% END %] [% IF ( filter_approved_pending ) %]<span>Displaying pending terms</span>[% END %] [% IF ( filter_approved_rej ) %]<span>Displaying rejected terms</span>[% END %] </h4> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152523|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 152527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152527&action=edit Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Fridolin Somers from comment #2)
Tricky indeed.
In my opinion, we should use the all phrase to have context and no %s :
<h4> [% IF ( filter_approved_all ) %]<span>Displaying all terms</span>[% END %] [% IF ( filter_approved_ok ) %]<span>Displaying approved terms</span>[% END %] [% IF ( filter_approved_pending ) %]<span>Displaying pending terms</span>[% END %] [% IF ( filter_approved_rej ) %]<span>Displaying rejected terms</span>[% END %] </h4>
Even better! I redid the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152527|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152553&action=edit Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152553|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155475&action=edit Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple working patch, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34081 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34079 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org