https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |critical Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So Koha install is broken using the Debian package? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If I execute: log4perl_component() { local config=$1 local component=$2 if [ grep -q -x "log4perl.logger.$component" $config ]; then return 0 else return 1 fi } for site in $(koha-list); do log4perl_config="/etc/koha/sites/$site/log4perl.conf" if ! log4perl_component $log4perl_config "sip"; then echo $site fi done I get xxx.pl: line 67: [: too many arguments Looks like we need another change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15253, 25032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 [Bug 15253] Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- IIUC from various IRC discussions, the cleanest[1] way to test package install patches while being simple[1] enough to be less likely to messed things up is: - apply comment 4 - make packages with https://hub.docker.com/r/koha/koha-dpkg - spin a standard Debian (9?) however one wants (container, VM, VPS) - install the packages following https://wiki.koha-community.org/wiki/Koha_on_Debian [1] for someone without experience with building packages and installing Koha from them -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #2)

So Koha install is broken using the Debian package?

Arguably yes. The majority of the install works correctly, but it looks like it ditches out at the end of koha-common.postinst. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #9)

(In reply to Victor Grousset/tuxayo from comment #6)

...

IIUC from various IRC discussions, the cleanest[1] way to test package install patches while being simple[1] enough to be less likely to messed things up is:

- apply comment 4 - make packages with https://hub.docker.com/r/koha/koha-dpkg - spin a standard Debian (9?) however one wants (container, VM, VPS) - install the packages following https://wiki.koha-community.org/wiki/Koha_on_Debian

[1] for someone without experience with building packages and installing Koha from them

That's mostly correct, although "install the packages" would need to use either "apt install ./koha-common<blahblah>" or "dpkg -i koha-common<blahblah>"

For making packages, I use my own Docker image (https://gitlab.com/minusdavid/koha-deb-builder-docker), but I imagine there's community support for https://hub.docker.com/r/koha/koha-dpkg, so that's probably better for someone without experience.

That's interesting, David. Mine is not community per-se. I like yours, might steal some of it for mine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)

Created attachment 104921 [details] [review] Bug 25510: Fix syntax error in koha-common.postinst

I'm getting the following errors: /var/lib/dpkg/info/koha-common.postinst: 155: /var/lib/dpkg/info/koha-common.postinst: !log4perl_component: not found /var/lib/dpkg/info/koha-common.postinst: 168: /var/lib/dpkg/info/koha-common.postinst: !log4perl_component: not found /var/lib/dpkg/info/koha-common.postinst: 184: /var/lib/dpkg/info/koha-common.postinst: !log4perl_component: not found I think we need that space between the ! and the function name. I'll add a patch for that and try again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #13)

Created attachment 105005 [details] [review] Bug 25510: Put space between negation operator and function name

This patch puts a space between the negation operator ! and the function name (ie log4perl_component).

With this patch, there are no longer error messages... but log4perl_component() doesn't look like it's working correctly because it just keeps appending to /etc/koha/sites/$site/log4perl.conf -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25524 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25524 [Bug 25524] Debian packages always append to /etc/koha/sites/$site/log4perl.conf -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indeed, I had the space in my test script but did not correctly applied the changes :-/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105005|0 |1 is obsolete| | --- Comment #19 from David Cook <dcook@prosentient.com.au> --- Created attachment 105008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105008&action=edit Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to David Cook from comment #9)

(In reply to Victor Grousset/tuxayo from comment #6)

...

- install the packages following https://wiki.koha-community.org/wiki/Koha_on_Debian

That's mostly correct, although "install the packages" would need to use either "apt install ./koha-common<blahblah>" or "dpkg -i koha-common<blahblah>"

`apt-get install koha-common` is indeed part of https://wiki.koha-community.org/wiki/Koha_on_Debian I feel I didn't get your meaning. Thanks a lot for the signing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25529 [Bug 25529] [OMNIBUS] 20.05 debian packages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 105053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105053&action=edit Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #23)

Thanks Tomas :)

We can't forget Bug 25524 either, as fixing Bug 25510 will cause Bug 25524 to become an issue.

I know. But internet gets painfully slow here around 8 pm with all the neighbours streamming Netflix et al, and I got pulled to the kitchen to make dinner :-D I have everything set to properly QA all this packaging bugs (koha-dpkg, vagrant+virtualbox) I just need more time as installing 19.11 (and deps) to test upgrades takes a lot of time here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #28 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies-not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- (In reply to Joy Nelson from comment #29)

not sure how to push this to 19.11.x branch.

Oh right, it'll need a different patch, as the koha-common.postinst in 19.11 is a fair bit different to master. I did my own local 19.11 patch but I meant to put one up here too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- Created attachment 105135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105135&action=edit [19.11] Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105134|0 |1 is obsolete| | Attachment #105135|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105152&action=edit Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #105053|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105153|Bug 25510: Put space |[19.11] Bug 25510: Put description|between negation operator |space between negation |and function name |operator and function name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #38 from David Cook <dcook@prosentient.com.au> --- (In reply to Joy Nelson from comment #36)

19.11.x patches reviewed by Kyle and pushed by me for 19.11.06 Thanks!

Woo! You're welcome ^_^. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #40 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.