[Bug 25992] New: SIP2 server doesn't start – Undefined subroutine set_logger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Bug ID: 25992 Summary: SIP2 server doesn't start – Undefined subroutine set_logger Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com, kyle@bywatersolutions.com After the SIP2 server refactoring in Bug 15253 the sip2 server doesn't start anymore because of this error:
Undefined subroutine &C4::SIP::SIPServer::set_logger called at /kohadevbox/koha/C4/SIP/SIPServer.pm
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP2 server doesn't start – |SIP2 server doesn't start - |Undefined subroutine |Undefined subroutine |set_logger |set_logger -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 106928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106928&action=edit Bug 25992: Make SIP2 logger subroutines exportable to prevent crash If the subroutines are not exportable we get the following crash:
Undefined subroutine &C4::SIP::SIPServer::set_logger
To test: In kohadevbox run for example: $ ps -aux # check that no existing sip server is running, kill the process if exists $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information After applying this patch the Undefined subroutine error should be gone. Note: when using the sip_cli_emulator.pl the credentials can be anything. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106928|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106929&action=edit Bug 25992: Make SIP2 logger subroutines exportable to prevent crash If the subroutines are not exportable we get the following crash:
Undefined subroutine &C4::SIP::SIPServer::set_logger
To test: In kohadevbox run for example: $ ps -aux # check that no existing sip server is running, kill the process if exists $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information After applying this patch the Undefined subroutine error should be gone. Note: when using the sip_cli_emulator.pl the credentials can be anything. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@helsinki.fi |ity.org | QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15253 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15253 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 [Bug 15253] Add Koha::Logger based logging for SIP2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106929|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106933&action=edit Bug 25992: Make SIP2 logger subroutines exportable to prevent crash If the subroutines are not exportable we get the following crash:
Undefined subroutine &C4::SIP::SIPServer::set_logger
To test: In kohadevbox run for example: $ ps -aux # check that no existing sip server is running, kill the process if exists $ perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml $ koha/misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item 3999900000001 -m item_information After applying this patch the Undefined subroutine error should be gone. Note: when using the sip_cli_emulator.pl the credentials can be anything. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We are missing a test here, it's not normal to get this situation on stable branches. It won't block the push but it's worth investigating what could be done to make sure we won't face it anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've been looking at the lack of tests issue. The only way I found to test this is by using the emulator. I think we need to revisit SIP altogether to allow proper testing, but marked this one PQA for being a trivial fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Who signed the| |20.11.00 patch off| | Status|Passed QA |Pushed to master --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to master for 20.11, thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)| |20.11.00, 20.05.03 released in| | CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Bug 25992 depends on bug 15253, which changed state. Bug 15253 Summary: Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org