[Bug 15685] New: Allow creation of items (AcqCreateItem) to be customizable per-basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Bug ID: 15685 Summary: Allow creation of items (AcqCreateItem) to be customizable per-basket Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 47783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47783&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47783|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55094&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55094|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55096&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org --- Comment #4 from J Schmidt <jschmidt@switchinc.org> --- I used PTFS test set up to create test budget; test Ebsco vendor and baskets. The System Preference by default for AcqCreateItem is set to create an item when "placing an order"...mainpage says updgrade to 16.05 done.... Test 1. 2016_0902 basket had the basket's Create items when set to "when placing an order". Results: Success in terms of when creating a new item is prompted correctly upon adding a title to a new basket. This is the same as the default system preference, however.... Test 2. Basket's 'create items when' option is set to make an item when "receiving an order"... Results: Fail. I tried to skip adding an item record at the point of adding a new title to a test basket. I went to Accounting details to put in order record information. However, I was blocked on the QUANTITY field. It stayed at zero and didn't allow for a numeral (e.g., 1, 2). Once I click Add item record above that area, then the Quantity field gets filled in as '1' and I can save the newly ordered title. I closed the 2016_0902Test2 basket and hit receive shipment. I receive one title in the basket.... Software error screen appears....Can't locate object method "find" via package "Koha::Acquisition::Order" at /home/koha/src/acqui/orderreceive.pl line 113. I hit F5, refresh, then try to click text link to receive other title. Same thing. Test 3. New test basket has the 'create items when' option set to 'cataloging the record'... Results: same thing happened as in test 2. I next close that basket. Receive shipment on 89.00 dollar book. Software error. Can't locate object method "find" via package "Koha::Acquisition::Order" at /home/koha/src/acqui/orderreceive.pl line 113. Seems to fail but I'll try another sandbox soon. Hesistant to change the status yet in case my test plan was off. jls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #5 from J Schmidt <jschmidt@switchinc.org> --- (In reply to J Schmidt from comment #4)
I used PTFS test set up to create test budget; test Ebsco vendor and baskets. The System Preference by default for AcqCreateItem is set to create an item when "placing an order"...mainpage says updgrade to 16.05 done....
Test 1. 2016_0902 basket had the basket's Create items when set to "when placing an order". Results: Success in terms of when creating a new item is prompted correctly upon adding a title to a new basket. This is the same as the default system preference, however....
Test 2. Basket's 'create items when' option is set to make an item when "receiving an order"... Results: Fail. I tried to skip adding an item record at the point of adding a new title to a test basket. I went to Accounting details to put in order record information. However, I was blocked on the QUANTITY field. It stayed at zero and didn't allow for a numeral (e.g., 1, 2). Once I click Add item record above that area, then the Quantity field gets filled in as '1' and I can save the newly ordered title. I closed the 2016_0902Test2 basket and hit receive shipment. I receive one title in the basket.... Software error screen appears....Can't locate object method "find" via package "Koha::Acquisition::Order" at /home/koha/src/acqui/orderreceive.pl line 113. I hit F5, refresh, then try to click text link to receive other title. Same thing.
Test 3. New test basket has the 'create items when' option set to 'cataloging the record'... Results: same thing happened as in test 2. I next close that basket. Receive shipment on 89.00 dollar book. Software error. Can't locate object method "find" via package "Koha::Acquisition::Order" at /home/koha/src/acqui/orderreceive.pl line 113.
Seems to fail but I'll try another sandbox soon. Hesistant to change the status yet in case my test plan was off. jls.
In each case I had to create a brief, new bib record. couldn't locate a biblionumber from test database. That would be a better thing to use upon adding new titles to a basket.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Hi Jenny, I think the problem may have been that the schema needs to be updated in order to fully test this patch. I had similar results to yours, but after updating the schema (not possible on a sandbox) things worked correctly -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #7 from J Schmidt <jschmidt@switchinc.org> --- Okay. I'll work on another bug then based on what you are sharing here.. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #8 from delaye <stephane.delaye@biblibre.com> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 15685: <h1>Something went wrong !</h1>Applying: Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket .git/rebase-apply/patch:603: trailing whitespace. .git/rebase-apply/patch:668: trailing whitespace. w arning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Acquisition.pm M acqui/addorder.pl M acqui/addorderiso2709.pl M acqui/basket.pl M acqui/basketheader.pl M acqui/neworderempty.pl M acqui/orderreceive.pl M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M opac/opac-detail.pl .git/rebase-apply/patch:603: trailing whitespace. .git/rebase-apply/patch:668: trailing whitespace. w arning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl CONFLICT (content): Merge conflict in opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging acqui/orderreceive.pl Auto-merging acqui/neworderempty.pl Auto-merging acqui/basketheader.pl Auto-merging acqui/basket.pl Auto-merging acqui/addorderiso2709.pl Auto-merging acqui/addorder.pl Auto-merging C4/Acquisition.pm Patch failed at 0001 Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: Failed to merge in the changes. Bug 15685 - Allow creation of items (AcqCreateItem) to be customizable per-basket 55096 - Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-15685-Allow-creation-of-items-AcqCreateItem-to-2qN6Q0.patch . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would love to see this happen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|jweaver@bywatersolutions.co |nick@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55096|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57390&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57390|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57392&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57392|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57395&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57395|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57424&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Patch set doesn't take Edifact ordering into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57424|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57425&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57426&action=edit Bug 15685 [QA Followup] - Implement needed changes in Koha::Edifact::Order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57427&action=edit Bug 15685 [QA Followup] - Bug qa script errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests are missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 57425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57425 Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket Review of attachment 57425: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15685&attachment=57425) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +2964,4 @@
`basketgroupid` int(11), -- links this basket to its group (aqbasketgroups.id) `deliveryplace` varchar(10) default NULL, -- basket delivery place `billingplace` varchar(10) default NULL, -- basket billing place + create_items ENUM('ordering', 'receiving', 'cataloguing') default NULL; -- when items should be created for orders in this basket
The semicolon needs to be a comma, and an atomicupdate needs to be added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64918&action=edit Bug 15685 - QA Followup DB revision fixes Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57425|0 |1 is obsolete| | Attachment #57426|0 |1 is obsolete| | Attachment #57427|0 |1 is obsolete| | Attachment #64918|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64919&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64920&action=edit Bug 15685 [QA Followup] - Implement needed changes in Koha::Edifact::Order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64921&action=edit Bug 15685 [QA Followup] - Bug qa script errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64922&action=edit Bug 15685 - QA Followup DB revision fixes Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, very interested to see this one make it in. Took a look at the code and noticed some merge markers were left in: b/acqui/finishreceive.pl +<<<<<<< HEAD $unitprice = Koha::Number::Price->new( $unitprice )->unformat(); #need old receivedate if we update the order, parcel.pl only shows the right parcel this way FIXME +======= -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64919|0 |1 is obsolete| | Attachment #64920|0 |1 is obsolete| | Attachment #64921|0 |1 is obsolete| | Attachment #64922|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65119&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65120&action=edit Bug 15685 [QA Followup] - Implement needed changes in Koha::Edifact::Order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65121&action=edit Bug 15685 [QA Followup] - Bug qa script errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65122&action=edit Bug 15685 - QA Followup DB revision fixes Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still trying to give this a second sign-off as I think this will make life a lot easier. Sadly, I ran into a big problem: AcqCreateItem is set to: on order 1) The method create_items is not covered by tests! - Create a new basket, choose: on receive - Add to basket by searching for an existing record in your catalog - Click order on one of the results => Internal server error, translates to: The method create_items is not covered by tests! Can't test further from here :( 2) The test file should not be named Basket.pm, but Basket.t :) 3) Patch reintroduced a typo (not really blocking) -#need old receivedate if we update the order, parcel.pl only shows the right parcel this way FIXME +#need old recievedate if we update the order, parcel.pl only shows the right parcel this way FIXME Tiny stuff (definitely non-blocker, maybe for later): - Baskets created before the introduction of the feature don't show the information about item creation on the basket summary page - Editing a basket after inititally creating it, doesn't offer the option to change. This makes a lot of sense, but maybe it would be good to display the selection as information (not changeable). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65119|0 |1 is obsolete| | Attachment #65120|0 |1 is obsolete| | Attachment #65121|0 |1 is obsolete| | Attachment #65122|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65895&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65896&action=edit Bug 15685 [QA Followup] - Implement needed changes in Koha::Edifact::Order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65897&action=edit Bug 15685 [QA Followup] - Bug qa script errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65898&action=edit Bug 15685 - QA Followup DB revision fixes Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65899&action=edit Bug 15685 - Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65900&action=edit Bug 15685 - QA followup - fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66119&action=edit [SIGNED OFF] Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66120&action=edit [SIGNED OFF] Bug 15685 [QA Followup] - Implement needed changes in Koha::Edifact::Order Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66121&action=edit [SIGNED OFF] Bug 15685 [QA Followup] - Bug qa script errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66122&action=edit [SIGNED OFF] Bug 15685 - QA Followup DB revision fixes Unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66123&action=edit [SIGNED OFF] Bug 15685 - Schema changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66124&action=edit [SIGNED OFF] Bug 15685 - QA followup - fix typo Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65895|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65896|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65897|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65898|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65899|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Absolutely love the feauture! This makes acquisitions so much more flexible especially for all the cases where you don't want to create items, like for electronic resources. Can't want to get my hands on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66119|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66120|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66122|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67638&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67639&action=edit Bug 15685: Implement needed changes in Koha::Edifact::Order Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67640&action=edit Bug 15685: (QA followup) Fix qa script errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67641&action=edit Bug 15685: QA Followup DB revision fixes Unit tests Edit: fixed the update step description (tcohen) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67642&action=edit Bug 15685: Schema changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67643&action=edit Bug 15685: (QA followup) Fix typo Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67644&action=edit Bug 15685: (followup) K:A:O->find and ->fetch are no longer used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67645&action=edit Bug 15685: (QA followup) Tidy tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #52 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67646&action=edit Bug 15685: POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67647&action=edit Bug 15685: Add tests for Koha::Acquisition::Order->basket Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've rebased the patches and checked everyting is ok regarding the changes introduced by bug 19256 in Koha::Acquisition::Order(s). Added tests for Koha::Acquisition::Order::basket (found a bug in the meantime). Please re-test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67638|0 |1 is obsolete| | Attachment #67639|0 |1 is obsolete| | Attachment #67640|0 |1 is obsolete| | Attachment #67641|0 |1 is obsolete| | Attachment #67642|0 |1 is obsolete| | Attachment #67643|0 |1 is obsolete| | Attachment #67644|0 |1 is obsolete| | Attachment #67645|0 |1 is obsolete| | Attachment #67646|0 |1 is obsolete| | Attachment #67647|0 |1 is obsolete| | --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67689&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67690&action=edit Bug 15685: Implement needed changes in Koha::Edifact::Order Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67691&action=edit Bug 15685: (QA followup) Fix qa script errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67692&action=edit Bug 15685: QA Followup DB revision fixes Unit tests Edit: fixed the update step description (tcohen) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67693&action=edit Bug 15685: Schema changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67694&action=edit Bug 15685: (QA followup) Fix typo Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67695&action=edit Bug 15685: (followup) K:A:O->find and ->fetch are no longer used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67696&action=edit Bug 15685: (QA followup) Tidy tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67697&action=edit Bug 15685: POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #64 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67698&action=edit Bug 15685: Add tests for Koha::Acquisition::Order->basket Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Some adjustments are required: 1. Update DB entry must use column_exists() 2. t/db_dependent/Acquisition/CancelReceipt.t and t/db_dependent/Acquisition/TransferOrder.t are failing with Can't use string ("Koha::Acquisition::Order") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Object.pm line 275. 3. Koha::EDI and circ/reserveratios.pl are still using AcqCreateItem from the pref 4. On basketheader.pl?booksellerid=1&op=add_form, the values for the dropdown "Create items when:" ended with a '.' I'd say it should be removed or moved out the options. 5. This looks like a typo (basketheader.tt): - <input type="hidden" name="is_an_edit" value="1" /> + <input type="hidden" name="rs_an_edit" value="1" /> 6. Koha::Acquisition::Order->basket must use DBIx::Class rs 7. Double check the code in addorderiso2709, it is buggy (GetBasket and Koha::Baskets->find calls) Can't call method "effective_create_items" on unblessed reference at /home/vagrant/kohaclone/acqui/addorderiso2709.pl line 107. 8. Change in acqui/basket.pl is not needed (basket passed twice to the template) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67884&action=edit Bug 15685: Followup - address QA issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67689|0 |1 is obsolete| | Attachment #67690|0 |1 is obsolete| | Attachment #67691|0 |1 is obsolete| | Attachment #67692|0 |1 is obsolete| | Attachment #67693|0 |1 is obsolete| | Attachment #67694|0 |1 is obsolete| | Attachment #67695|0 |1 is obsolete| | Attachment #67696|0 |1 is obsolete| | Attachment #67697|0 |1 is obsolete| | Attachment #67698|0 |1 is obsolete| | Attachment #67884|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67898&action=edit Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket This adds a new basket attribute (create_items) that can optionally be set to override AcqCreateItem. The following have been modified to reflect this (with the value of create_items that causes them to behave differently in parentheses): * Cancelling receipt of an order (receiving) * Creating an order by hand or from MARC (ordering) * Receiving an order (receiving) * Showing orders with uncertain price (ordering) * Showing orders (receiving) * Showing acquisition details in the OPAC (ordering) Test plan: 1) Create baskets with "Create items when:" set to ordering, receiving, cataloging and unset. 2) Test each of the above for each of these baskets, verifying that the basket-specific attribute overrides AcqCreateItem if set and falls back to the syspref otherwise. NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it was redundant; the code path in question cannot be triggered unless create_items/AcqCreateItems is set to the correct value anyway. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Barbara Fondren <bfondren@roundrocktexas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67899&action=edit Bug 15685: Implement needed changes in Koha::Edifact::Order Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67900&action=edit Bug 15685: (QA followup) Fix qa script errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67901&action=edit Bug 15685: QA Followup DB revision fixes Unit tests Edit: fixed the update step description (tcohen) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67902&action=edit Bug 15685: (QA followup) Fix typo Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67903&action=edit Bug 15685: (followup) K:A:O->find and ->fetch are no longer used Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67904&action=edit Bug 15685: (QA followup) Tidy tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67905&action=edit Bug 15685: POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67906&action=edit Bug 15685: Add tests for Koha::Acquisition::Order->basket Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67907&action=edit Bug 15685: Followup - address QA issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67908&action=edit Bug 15685: Fix DB columns order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67909&action=edit Bug 15685: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 67907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67907 Bug 15685: Followup - address QA issues Review of attachment 67907: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15685&attachment=67907) ----------------------------------------------------------------- - my $basket = Koha::Acquisition::Order->find( $order->{ordernumber} )->basket; + my $basket = Koha::Acquisition::Orders->find({ordernumber => $ordernumber})->basket; Why? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- my $basket = Koha::Acquisition::Orders->find($ordernumber)->basket; should be enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67910&action=edit Bug 15685: Avoid "Use of uninitialized value" warning in logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67911&action=edit Bug 15685: Send the basket to _cancel_items_receipt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #82)
Created attachment 67911 [details] [review] Bug 15685: Send the basket to _cancel_items_receipt
Nick, does this last patch makes sense to you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #84 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #83)
Nick, does this last patch makes sense to you?
Yes, there is more we could switch to use of objects, but I didn't want to get sidetracked -- You are receiving this mail because: You are watching all bug changes.
my $basket = Koha::Acquisition::Orders->find($ordernumber)->basket;
should be enough. Indeed - I was debugging a typo so was more specific to be sure error was not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 --- Comment #85 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #80) there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19468 [Bug 19468] Can't create basket in acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695 [Bug 19695] Uncertain prices should not use find in list context -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20446 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20446 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20446 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 [Bug 20446] QUOTES processing broken by run time error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There's a typo in this: Koha/EDI.pm - $basket->effective_create_item (Missing the 's'), which will cause Koha::Objects to throw an 'The method is untested' error whenever his codepath is followed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 [Bug 22611] Typo introduced into Koha::EDI by bug 15685 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43541 [Bug 43541] Hold ratios report counts item-less orders inconsistently -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org