https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Some adjustments are required: 1. Update DB entry must use column_exists() 2. t/db_dependent/Acquisition/CancelReceipt.t and t/db_dependent/Acquisition/TransferOrder.t are failing with Can't use string ("Koha::Acquisition::Order") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Object.pm line 275. 3. Koha::EDI and circ/reserveratios.pl are still using AcqCreateItem from the pref 4. On basketheader.pl?booksellerid=1&op=add_form, the values for the dropdown "Create items when:" ended with a '.' I'd say it should be removed or moved out the options. 5. This looks like a typo (basketheader.tt): - <input type="hidden" name="is_an_edit" value="1" /> + <input type="hidden" name="rs_an_edit" value="1" /> 6. Koha::Acquisition::Order->basket must use DBIx::Class rs 7. Double check the code in addorderiso2709, it is buggy (GetBasket and Koha::Baskets->find calls) Can't call method "effective_create_items" on unblessed reference at /home/vagrant/kohaclone/acqui/addorderiso2709.pl line 107. 8. Change in acqui/basket.pl is not needed (basket passed twice to the template) -- You are receiving this mail because: You are watching all bug changes.