[Bug 9957] New: Missing cancel link on subfield editing page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Bug ID: 9957 Summary: Missing cancel link on subfield editing page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de When editing subfields it's a bit irritating that the save link is placed on top. So most of the time you have to scroll back up, especially when you have changed things in the 'more constraints' part. Also, unlike on other pages there is no 'cancel' link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17852&action=edit Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17852|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17858&action=edit Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17858|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17860&action=edit [PASSED QA] Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, improves consistency and works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org