[Bug 9266] New: Managing tags / reject: Error "Unbekannte Operation (ablehnen)" in translated staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Bug ID: 9266 Summary: Managing tags / reject: Error "Unbekannte Operation (ablehnen)" in translated staff client Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch CC: gmcharlt@gmail.com Created attachment 14013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14013&action=edit Error while rejecting tag in translated staff client (German) Rejecting tags results in message: Unbekannte Operation (ablehnen) mit 2 Begriff(en). Steps to reproduce: 1) Go to Home › Tools › Tags 2) Filter tags to show a list of tags. Check checkboxes of tags you want to reject. Click "Reject" at the bottom Result in English staff client: "Rejected 1 Term(s). " Result in German Staff client: "Unbekannte Operation (ablehnen) mit 1 Begriff(en)." (Unknown operation (ablehnen)...) Same with approve. I tested on a 3.9 demo server, German translation installed. Can somebody confirm for newer version and for other languages? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr, | |katrin.fischer@bsz-bw.de Component|Staff Client |I18N/L10N Version|unspecified |master Severity|minor |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested in 3.10.1. I can reproduce the problem using the checkboxes and the buttons below the list of tags. Also I noted some other translation related problems: 1) On the OPAC detail page there is a little icon in front of 'Add' that is missing in the German templates before 'Hinzufügen'. 2) When you use the 'reject' and 'accept' links in the list of terms, after rejecting or accepting one of the buttons appears in English. Looking like: Bestätigt (= Accepted) | Reject Approve | Abgelehnt (= Rejected) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10022 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- This may be corrected by Bug 10022. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Summary|Managing tags / reject: |Untranslated strings in |Error "Unbekannte Operation |tags moderation |(ablehnen)" in translated | |staff client | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Since the patch for Bug 10022 fixes the original problem described in this bug I'm having Katrin's #2 problem above take over this report:
2) When you use the 'reject' and 'accept' links in the list of terms, after rejecting or accepting one of the buttons appears in English.
I could not reproduce this problem:
1) On the OPAC detail page there is a little icon in front of 'Add' that is missing in the German templates before 'Hinzufügen'.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17730&action=edit Bug 9266 - Untranslated strings in tags moderation There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17730|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|oleonard@myacpl.org |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17761&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17761|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 17778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17778&action=edit Bug 9266 - Untranslated strings in tags moderation There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mason James <mtj@kohaaloha.com>
QA-comment: tested ok, passing QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org