[Bug 32605] New: Restore some form styling from before the redesign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Bug ID: 32605 Summary: Restore some form styling from before the redesign Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 We've already fixed a dozen or so form layout problems since the redesign was implemented, and there are more popping up. I think it's time to restore the CSS used to style forms from before the redesign. The general pattern of layouts will remain the same, but a wider variety of form markup will be supported. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145201&action=edit Bug 32605: Restore some form styling from before the redesign This patch pulls styles from pre-22.11 staff-global.scss related to the styling of fieldset.rows and contents. The old CSS is more verbose but it has been better proven to hold up in a variety of situations. The patch makes only one template change, a minor correction to the basket groups form. To test, apply the patch and rebuild the staff interface SCSS. Test as many forms as possible to confirm that everything is still correct. Forms affected are ones shown in the main body of the page, not in sidebars. Some good examples: Editing patrons, subscriptions, patron categories, notices, item types. This patch should help outstanding bugs 32513, 32543, and 32591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't see any differences on the patron edit form. Where am I supposed to look at? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Most forms should look the same. Others, referenced in the outstanding bugs listed above, should look better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |marie-luce.laflamme@inlibro | |.com --- Comment #4 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- It works well in the form "label-edit-layout.pl" (bug=32513 ), since terms «list fields» are back on the left-hand side. However, the other mentioned forms are still buggy. Examples: (bug=32591) in the "Batch patron deletion and anonymization" form on the cleanborrowers.pl page --> There is no significant change with or without the patch. (bug=32543) in "New patron category" form on the page categories.pl?op=add_form --> the "Until date" field is still misaligned and you can notice a bigger calendar box on the page after the applying the patch. see https://staff-m2linlibro.sandbox.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marie-Luce Laflamme from comment #4)
(bug=32591) in the "Batch patron deletion and anonymization" form on (bug=32543) in "New patron category" form
I think both these issues are a side-effect of Bug 31943 and would be fixed by the patch on Bug 32606. -- You are receiving this mail because: You are watching all bug changes.
Patron attributes)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 145916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145916&action=edit Screenshot - patron card layout form Things I noted: 1. Very large date input fields are fixed by bug 32606 (I applied that patch, and for the ones I tried this was fixed) 2. Radio button selectors: for some of the forms I tested, the label is indented and aligns with other fields' input boxes (for example: Import patrons 3. Radio button selectors: for several forms I tested, there is no space between the radio button and the text that comes after (for example: Edit patron card layout) 4. Hint text larger: I personally don't mind this (for example: patron edit form > date of birth) 5. Label alignment when wrapped: previously input fields were centered on the label, now aligned to the top of the label (for example: patron edit form > Library setup > expiry date ....; patron category edit form) Specific forms ============== Patron edit form: - date of birth + other date fields: input field "huge" - can confirm this is fixed by bug 32606 - primary phone, secondary phone, secondary email fields, ZIP/Postal code: these labels are wrapped now, previously they were on one line - label alignment when wrapped: previously input fields were centered on the label, now aligned to the top of the label - "Allow auto-renewal of items": label indented - starts where other input fields are - Patron identity: raido buttons start where otehr input fields are Patron category: - Enrolment period: "Choose one" text very large (this was the case before the patch), date field huge (fixed with bug 32606), text size of hints/help the same size (or larger?) than labels Edit patron card layout (screenshot attched): - All msialigned and indented: fieldsets all indented - general settings, then field 1, 2 and 3 and further indented; text input fields are aligned to the left with the start of all labels Import patrons: - Hide default value fields: drop down lists previously had a grey background (for example, Home library and Patron category) - this seems to only be this form, other ones I looked at were okay (for example: patron categories); date fields huge (fixed with bug 32606) - Hide preserve value fields: introductory text was aligned left with the start of the labels, but is now aligned after the label and in line with the start of the check boxes/input fields - If matching record is already in the borrowers table: radio buttons are all indented, and there is no space between the input field and the label that comes after it - Patron attributes: same as "If matching record is already in the borrowers table" Notices and slips: - Not related to this, but just noting that the input field where the notice is put goes over the the right hand edge - even at a reasonable width Item types: looks OK Edit items: looks OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145201|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146348&action=edit Bug 32605: Restore some form styling from before the redesign This patch pulls styles from pre-22.11 staff-global.scss related to the styling of fieldset.rows and contents. The old CSS is more verbose but it has been better proven to hold up in a variety of situations. The patch makes only one template change, a minor correction to the basket groups form. To test, apply the patch and rebuild the staff interface SCSS. Test as many forms as possible to confirm that everything is still correct. Forms affected are ones shown in the main body of the page, not in sidebars. Some good examples: Editing patrons, subscriptions, patron categories, notices, item types. This patch should help outstanding bugs 32513, 32543, and 32591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146349&action=edit Bug 32605: (follow-up) Additional fixes This patch makes some further changes to form CSS in order to improve consistency. Some templates have also been modified to improve layout. - Acquisitions -> New vendor - Staff interface home -> Patrons requesting modifications - Reports -> Saved SQL reports - Serials -> New subscription - Tools -> Import patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #6)
5. Label alignment when wrapped: previously input fields were centered on the label, now aligned to the top of the label
This is intentional.
- primary phone, secondary phone, secondary email fields, ZIP/Postal code: these labels are wrapped now, previously they were on one line
This is to be expected.
- "Allow auto-renewal of items": label indented - starts where other input fields are - Patron identity: raido buttons start where otehr input fields are
This is the intended layout.
Patron category: Edit patron card layout Import patrons
These pages should be improved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146348|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 146359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146359&action=edit Bug 32605: Restore some form styling from before the redesign This patch pulls styles from pre-22.11 staff-global.scss related to the styling of fieldset.rows and contents. The old CSS is more verbose but it has been better proven to hold up in a variety of situations. The patch makes only one template change, a minor correction to the basket groups form. To test, apply the patch and rebuild the staff interface SCSS. Test as many forms as possible to confirm that everything is still correct. Forms affected are ones shown in the main body of the page, not in sidebars. Some good examples: Editing patrons, subscriptions, patron categories, notices, item types. This patch should help outstanding bugs 32513, 32543, and 32591 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146349|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 146360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146360&action=edit Bug 32605: (follow-up) Additional fixes This patch makes some further changes to form CSS in order to improve consistency. Some templates have also been modified to improve layout. - Acquisitions -> New vendor - Staff interface home -> Patrons requesting modifications - Reports -> Saved SQL reports - Serials -> New subscription - Tools -> Import patrons Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #12 from David Nind <david@davidnind.com> --- Thanks Owen for the additional information and fixing the issues identified. I've signed off, even though I haven't checked every form. I'm making a big assumption that follow-up bugs will be created for any identified issues once this passes QA and gets pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146359|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146495&action=edit Bug 32605: Restore some form styling from before the redesign This patch pulls styles from pre-22.11 staff-global.scss related to the styling of fieldset.rows and contents. The old CSS is more verbose but it has been better proven to hold up in a variety of situations. The patch makes only one template change, a minor correction to the basket groups form. To test, apply the patch and rebuild the staff interface SCSS. Test as many forms as possible to confirm that everything is still correct. Forms affected are ones shown in the main body of the page, not in sidebars. Some good examples: Editing patrons, subscriptions, patron categories, notices, item types. This patch should help outstanding bugs 32513, 32543, and 32591 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146360|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146496&action=edit Bug 32605: (follow-up) Additional fixes This patch makes some further changes to form CSS in order to improve consistency. Some templates have also been modified to improve layout. - Acquisitions -> New vendor - Staff interface home -> Patrons requesting modifications - Reports -> Saved SQL reports - Serials -> New subscription - Tools -> Import patrons Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All looks good to me.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32022 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We think this might be the culprit causing the regression in the screenshots added to the end of bug 32022 earlier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Bug 34072 is the cause. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34654 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32605 Bug 32605 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org