[Bug 41055] New: Missing accesskey attribute for print button (shortcut P)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Bug ID: 41055 Summary: Missing accesskey attribute for print button (shortcut P) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: johanna.raisa@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The print buttons labeled "Don't check out, confirm hold, and print slip (P)" and "Don't check out and print slip (P)" in circulation.tt are missing the accesskey="p" attribute, which prevents users from using the keyboard shortcut "P" to activate the button. The button appears when you are trying to checkout an item that is waiting for other patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 188158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188158&action=edit Bug 41055: add missing accesskey attribute for print button This commit adds the missing accesskey attribute to the print button in the circulation template. Test plan: 1. Try to checkout an item that is waiting for pickup. 2. Try to print the checkout receipt using the alt+shift+p keyboard shortcut. 3. Verify that nothing happens when using the shortcut. 4. After applying this commit, try the same steps again. 5. Verify that the print button now works with the alt+shift+p keyboard shortcut. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188158|0 |1 is obsolete| | --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 188668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188668&action=edit Bug 41055: add missing accesskey attribute for print button This commit adds the missing accesskey attribute to the print button in the circulation template. Test plan: 1. Try to checkout an item that is waiting for pickup. 2. Try to print the checkout receipt using the alt+shift+p keyboard shortcut. 3. Verify that nothing happens when using the shortcut. 4. After applying this commit, try the same steps again. 5. Verify that the print button now works with the alt+shift+p keyboard shortcut. Sponsored-by: Koha-Suomi Oy Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Easy patch, nice effect. Thanks Johanna! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188668|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193042&action=edit Bug 41055: add missing accesskey attribute for print button This commit adds the missing accesskey attribute to the print button in the circulation template. Test plan: 1. Try to checkout an item that is waiting for pickup. 2. Try to print the checkout receipt using the alt+shift+p keyboard shortcut. 3. Verify that nothing happens when using the shortcut. 4. After applying this commit, try the same steps again. 5. Verify that the print button now works with the alt+shift+p keyboard shortcut. Sponsored-by: Koha-Suomi Oy Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the accesskey was promoted on the button, but didn't work, I am promoting this to a bug: <i class="fa fa-print"></i> Don't check out and print slip (P)</button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 --- Comment #7 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|26.05.00,25.11.03,25.05.09 |26.05.00,25.11.03,25.05.09, released in| |24.11.15 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11 for 24.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.05.00,25.11.03,25.05.09, |26.05.00,25.11.03,25.05.09, released in|24.11.15 |24.11.16 --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Will instead be released in 24.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41055 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org