[Bug 41679] New: Stock rotation repatriation modal can conflict with holds modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Bug ID: 41679 Summary: Stock rotation repatriation modal can conflict with holds modal Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate 1 - Enable StokcRotation system preference 2 - Navigate to Cataloging->Stock rotation 3 - Click '+ New rota' fill out with any values 4 - Click 'Manage->stages' for the Rota 5 - Add a stage for Centerville for 1 day, and Midway for 1 day 6 - Return to rotas 7 - Click Manage->items for the rota 8 - Add an item 9 - Return to rotas 10 - Click 'Activate' 11 - On the command line run the stock rotation job perl misc/cronjobs/stockrotation.pl -x 12 - There should be one item for initiation 13 - Run it again, there should be one stationary item 14 - Place an item specific hold for the item, for pickup at Midway 15 - Check the item in at centerville, confirm transfer 16 - Check the item in at Midway, confirm hold 17 - Run the stock rotation job again 18 - There should be one item for repatriation 19 - Check in the item again 20 - Boom! You get two overlapping modals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192235&action=edit Bug 41679: Fix overlapping modals when hold conflicts with stock rotation transfer When checking in an item that has both a hold and a stock rotation repatriation transfer, both modals would appear simultaneously, overlapping each other and making it impossible to interact with either one properly. This occurred because: 1. The hold modal showed when 'waiting' was set 2. The transfer modal condition checked for 'reserved' but not 'waiting' 3. Both modals had the "block" class, causing simultaneous display This patch ensures holds take precedence over stock rotation transfers by adding a check for the 'waiting' flag to the transfer modal condition. When a hold is found, only the hold modal displays. The stock rotation transfer can be handled at a subsequent check-in, which is appropriate since holds are patron-facing and time-sensitive, while stock rotation is an internal process that can be deferred. Test plan: 1. Enable StockRotation system preference 2. Navigate to Cataloging->Stock rotation 3. Click '+ New rota' and fill out with any values 4. Click 'Manage->stages' for the Rota 5. Add a stage for Centerville for 1 day, and Midway for 1 day 6. Return to rotas 7. Click Manage->items for the rota 8. Add an item 9. Return to rotas 10. Click 'Activate' 11. On the command line run the stock rotation job: perl misc/cronjobs/stockrotation.pl -x 12. There should be one item for initiation 13. Run it again, there should be one stationary item 14. Place an item specific hold for the item, for pickup at Midway 15. Check the item in at Centerville, confirm transfer 16. Check the item in at Midway, confirm hold 17. Run the stock rotation job again: perl misc/cronjobs/stockrotation.pl -x 18. There should be one item for repatriation 19. Check in the item again at Midway 20. Before patch: Two overlapping modals appear (hold + transfer) 21. After patch: Only the hold modal appears 22. Confirm the hold - no transfer modal should appear 23. The stock rotation transfer will be handled at the next check-in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192661&action=edit Bug 41679: Fix overlapping modals when hold conflicts with stock rotation transfer When checking in an item that has both a hold and a stock rotation repatriation transfer, both modals would appear simultaneously, overlapping each other and making it impossible to interact with either one properly. This occurred because: 1. The hold modal showed when 'waiting' was set 2. The transfer modal condition checked for 'reserved' but not 'waiting' 3. Both modals had the "block" class, causing simultaneous display This patch ensures holds take precedence over stock rotation transfers by adding a check for the 'waiting' flag to the transfer modal condition. When a hold is found, only the hold modal displays. The stock rotation transfer can be handled at a subsequent check-in, which is appropriate since holds are patron-facing and time-sensitive, while stock rotation is an internal process that can be deferred. Test plan: 1. Enable StockRotation system preference 2. Navigate to Cataloging->Stock rotation 3. Click '+ New rota' and fill out with any values 4. Click 'Manage->stages' for the Rota 5. Add a stage for Centerville for 1 day, and Midway for 1 day 6. Return to rotas 7. Click Manage->items for the rota 8. Add an item 9. Return to rotas 10. Click 'Activate' 11. On the command line run the stock rotation job: perl misc/cronjobs/stockrotation.pl -x 12. There should be one item for initiation 13. Run it again, there should be one stationary item 14. Place an item specific hold for the item, for pickup at Midway 15. Check the item in at Centerville, confirm transfer 16. Check the item in at Midway, confirm hold 17. Run the stock rotation job again: perl misc/cronjobs/stockrotation.pl -x 18. There should be one item for repatriation 19. Check in the item again at Midway 20. Before patch: Two overlapping modals appear (hold + transfer) 21. After patch: Only the hold modal appears 22. Confirm the hold - no transfer modal should appear 23. The stock rotation transfer will be handled at the next check-in Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192661|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192984&action=edit Bug 41679: Fix overlapping modals when hold conflicts with stock rotation transfer When checking in an item that has both a hold and a stock rotation repatriation transfer, both modals would appear simultaneously, overlapping each other and making it impossible to interact with either one properly. This occurred because: 1. The hold modal showed when 'waiting' was set 2. The transfer modal condition checked for 'reserved' but not 'waiting' 3. Both modals had the "block" class, causing simultaneous display This patch ensures holds take precedence over stock rotation transfers by adding a check for the 'waiting' flag to the transfer modal condition. When a hold is found, only the hold modal displays. The stock rotation transfer can be handled at a subsequent check-in, which is appropriate since holds are patron-facing and time-sensitive, while stock rotation is an internal process that can be deferred. Test plan: 1. Enable StockRotation system preference 2. Navigate to Cataloging->Stock rotation 3. Click '+ New rota' and fill out with any values 4. Click 'Manage->stages' for the Rota 5. Add a stage for Centerville for 1 day, and Midway for 1 day 6. Return to rotas 7. Click Manage->items for the rota 8. Add an item 9. Return to rotas 10. Click 'Activate' 11. On the command line run the stock rotation job: perl misc/cronjobs/stockrotation.pl -x 12. There should be one item for initiation 13. Run it again, there should be one stationary item 14. Place an item specific hold for the item, for pickup at Midway 15. Check the item in at Centerville, confirm transfer 16. Check the item in at Midway, confirm hold 17. Run the stock rotation job again: perl misc/cronjobs/stockrotation.pl -x 18. There should be one item for repatriation 19. Check in the item again at Midway 20. Before patch: Two overlapping modals appear (hold + transfer) 21. After patch: Only the hold modal appears 22. Confirm the hold - no transfer modal should appear 23. The stock rotation transfer will be handled at the next check-in Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 --- Comment #5 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|26.05.00,25.11.03,25.05.09 |26.05.00,25.11.03,25.05.09, released in| |24.11.15 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11 for 24.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Will instead be released in 24.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03,25.05.09, |26.05.00,25.11.03,25.05.09, released in|24.11.15 |24.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41679 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org