https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 104493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104493&action=edit Bug 25409: Add missing "required" class to template Added "required" class to "itemtype" label in "onboardingstep5.tt" template. To test: 1) Start new instalation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "itemtype" label has no "required" class. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104493|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104499&action=edit Bug 25409: Add missing "required" class to template Added "required" class to "itemtype" label in "onboardingstep5.tt" template. To test: 1) Start new instalation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "itemtype" label has no "required" class. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104499|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104556&action=edit Bug 25409: Add missing "required" class to template Added "required" class to "itemtype" label in "onboardingstep5.tt" template. To test: 1) Start new instalation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "itemtype" label has no "required" class. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #5 from Slava Shishkin <slavashishkin@gmail.com> --- (In reply to Katrin Fischer from comment #4)

Welcome, Slava!

Katrin, thanks for your welcoming in the community! (also thanks Peter for supervising, Nugged for involving, and both for training) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #7 from Andrew Nugged <nugged@gmail.com> --- Katrin: It's more about teamwork then fame but one day all of us (me & my both trainees) we will be in contributors list – that will be achievement :), now we in a very intensive learning process how to become better Koha contributors mixed Finland-Ukraine team :). ... and this ticket is very simple... So our goal was more to go through the correct process of creation/testing/description/merging into master for simpler code, and it seems we doing well (Petro and Slava: thanks!) Let's proceed further. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #9 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 104634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104634&action=edit Bug 25409: Add missing “Required” text and “required” classes Highlight text with red by adding “required” class to the label and added red “Required” text next to select field in "onboardingstep5.tt" template. To test: 1) Start new installation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "Units" label has no "required" class and that there’s no “Required” text next to a select field. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #6)

If you want to, we could add mentored-by: lines to the patch to acknowledge their help.

I love to see these `Mentored-by: ` git trailers.. I think it really goes to show how much of a welcoming community we are and showcases us working together.. Great teamwork guys, nice to have you aboard. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104684&action=edit Bug 25409: Add missing "Required" text and "required" classes Highlight text with red by adding “required” class to the label and added red “Required” text next to select field in "onboardingstep5.tt" template. To test: 1) Start new installation. During onboarding tool phase you will be requested to create a new circulation rule. 2) Observe that "Units" label has no "required" class and that there’s no “Required” text next to a select field. 3) Apply patch. 4) Repeat step 2 (you can reload circulation rule creation page). 5) Observe the error is gone. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Slava, usually once a patch has PQA it's better to open a new bug for a new issue, this way one can proceed while the other is processed. This was quite a small change, so I am using my QA manager powers to move this back to Passed QA immediately :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #14 from Andrew Nugged <nugged@gmail.com> --- (In reply to Katrin Fischer from comment #13)

Ah, please beware: “required” wasn't liked by git-bz, I changed to "required" :)

yes, noted, sorry it was cross-messenger MacOS conversion, but now three of us know this so (high probability) won't happen again :). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 --- Comment #16 from Andrew Nugged <nugged@gmail.com> --- (In reply to Martin Renvoize from comment #10)

I love to see these `Mentored-by: ` git trailers.. I think it really goes to show how much of a welcoming community we are and showcases us working together..

okay, we will consider this. (oh, I should mention Joonas for mine earlier commits everywhere...)

Great teamwork guys, nice to have you aboard.

( /me glad to hear and melting in wide smile :) ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #19 from Joy Nelson <joy@bywatersolutions.com> --- pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.