[Bug 25417] New: Backdating returns and forgiving fines causes and internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Bug ID: 25417 Summary: Backdating returns and forgiving fines causes and internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - Checkout an item to a patron and make it overdue (can backdate the checkout) 2 - Make sure the itemtype has fines that will be charged 3 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 4 - Browse to Circulation->Check in 5 - In 'Checkin settings' backdate to before the due date and select forgive fines 6- Explode!!!!! Debit amount passed is not positive at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104535&action=edit Bug 25417: Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104536&action=edit Bug 25417: Prevent backdating returns and forgiving fines as the same time from causing an internal server error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104535|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 104575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104575&action=edit Bug 25417: Add unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104536|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 104576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104576&action=edit Bug 25417: Prevent backdating returns and forgiving fines as the same time from causing an internal server error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104578&action=edit [ALTERNATIVE-PATCH] Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, what are your thoughts on this alternative patch? I think it makes it more readable and avoid the ->store call as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104576|0 |1 is obsolete| | Attachment #104578|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104579&action=edit Bug 25417: Prevent negative debit amount on backdating returns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104579|0 |1 is patch| | Attachment #104579|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104579|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104580&action=edit Bug 25417: Prevent negative debit amount on backdating returns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104575|0 |1 is obsolete| | --- Comment #9 from didier <didier.gautheron@biblibre.com> --- Created attachment 104644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104644&action=edit Bug 25417: Add unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104580|0 |1 is obsolete| | --- Comment #10 from didier <didier.gautheron@biblibre.com> --- Created attachment 104645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104645&action=edit Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not sure I'm understanding the Unit test added here.. how, 'in real life' can you end up with a negative amountoutstanding amount?.. I ask as I'm not sure how it relates to the issue reported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #11)
Not sure I'm understanding the Unit test added here.. how, 'in real life' can you end up with a negative amountoutstanding amount?.. I ask as I'm not sure how it relates to the issue reported?
If someone pays an accruing fine and then the item is backdated via dropbox or something. It can easily happen that a patron drops something in the box, then comes inside and pays fines, not realizing one of them is the one they returned etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This would leave us with a zero value 'OVERDUE' fine with an 'UNRETURNED' status on the item even though the item has been returned. Took me a while to work through it and I'm still struggling to actually replicate the issue. I'll work on improving the test to clarify it's intent for this bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24763 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22539 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8338 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 [Bug 22539] Fines charged on back-dated checkin when item has been renewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12144 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104715&action=edit Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104716&action=edit Bug 25417: (QA follow-up) Restore 'fixing' of fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Some minor improvements to the test to highlight the requirement to 'fix' fines regardless of exemptfine. I'd still really love to see a test added to AddReturn to actually test the case highlighted by Nick in the first comment.. currently we still don't actually test that codepath as a whole. Let me know what you think of the final followup which I believe corrects the behavior as a whole. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104644|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104730&action=edit Bug 25417: Add unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104645|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104731&action=edit Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104715|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104732&action=edit Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104716|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104733&action=edit Bug 25417: (QA follow-up) Restore 'fixing' of fines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104734&action=edit Bug 25417: Add integration test for AddReturn Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That makes sense to me Martin, but I would prefer Nick or Kyle to confirm it with their QA stamp. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104730|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104735&action=edit Bug 25417: Add unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104731|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104736&action=edit Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104732|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104737&action=edit Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104733|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104738&action=edit Bug 25417: (QA follow-up) Restore 'fixing' of fines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104739&action=edit Bug 25417: (QA follow-up) Add integration test for AddReturn Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm happy with this now... This improves the behaviour to properly skip adding a FORGIVEN type credit for OVERDUES that have already been annulled by a backdated return with CalculateFinesOnBackdate. We still end up with a zero amount fine line, which I'm still not entirely sure about, but as that question has been unanswered in bugs 22539 and 8338 already I don't think to ask it here and holding up this fix is the correct action to take. I've also modified the clause to only skip on '0'.. if we somehow end up with a negative here we do still want to throw an exception as it highlights issues elsewhere in the codepaths prior to this point.. we should not just silently ignore that in my opinion. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Holding off on pushing until I get a final stamp from Kyle, Nick or Tomas.. all whom I believe are close enough to accounts or this issue to be able to confirm the logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104735|0 |1 is obsolete| | Attachment #104736|0 |1 is obsolete| | Attachment #104737|0 |1 is obsolete| | Attachment #104738|0 |1 is obsolete| | Attachment #104739|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104749&action=edit Bug 25417: Add unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104749|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104750&action=edit Bug 25417: Add unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104751&action=edit Bug 25417: Prevent negative debit amount on backdating returns Koha::Account->add_credit is expecting a positive amount. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104752&action=edit Bug 25417: (QA follow-up) Clarify _FixOverduesOnReturn test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104753&action=edit Bug 25417: (QA follow-up) Restore 'fixing' of fines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104754&action=edit Bug 25417: (QA follow-up) Add integration test for AddReturn Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #37 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #38 from Lucas Gass <lucas@bywatersolutions.com> --- For 19.05.x unit tests are failing: ok 9 - Credit amountoutstanding is correctly set to 0 not ok 33 - _FixOverduesOnReturn # Looks like you planned 14 tests but ran 9. # Failed test '_FixOverduesOnReturn' # at t/db_dependent/Circulation.t line 2587. No property debit_type_code for Koha::Account::Line# Looks like your test exited with 255 just after 33. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/46 subtests Not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org