[Bug 7940] New: Placing a hold on a single item from the staff cart causes errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Priority: P5 - low Change sponsored?: --- Bug ID: 7940 CC: gmcharlt@gmail.com Assignee: koha.sekjal@gmail.com Summary: Placing a hold on a single item from the staff cart causes errors QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Hold requests Product: Koha When reserving from the cart in the staff catalog - you get as far as "Enter patron card number or partial name". Once you have entered the name - it throws this error. Software error: Can't call method "field" on an undefined value at /home/koha/kohaclone/C4/Items.pm line 1556. For help, please send mail to the webmaster (staff@bywatersolutions.com), giving this error message and the time and date of the error. This happens when you are using the cart to order 1 item. (If you place more then 1 item in the cart, you do not get this error message) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9077&action=edit Bug 7940 - Placing a hold on a single item from the staff cart causes errors This is caused by the javascript function placeHold() in basket.pl The cause of this error is thus: when a staff member uses the cart to place holds on multiple items at once, the cart redirects to reserver/request.pl with the params 'biblionumbers' ( a string of biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param multi_hold with a value of 1. When multi_hold is enabled, request.pl splits the string 'biblionumbers' on those slashes and works on that list. In placeHold(), when only one item is checked, the system passes the param biblionumbers with a single biblionumber ( e.g. '5/' ) and does *not* pass the multi_hold param. This causes request.pl to not parse the biblionumbers param, and thus reserve.pl has no biblionumber to work on ( hence our error here ). There are two options to resolve this: A) Add the multi_hold param even for a single hold from the cart. B) In the event of a single hold being placed from the cart, switch to the standard single hold url ( i.e. request.pl?biblionumber=234 ) This commit resolves the situation using option B, as it seems more logical than using the multi-holds system for a single hold. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha.sekjal@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9077|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9078&action=edit Bug 7940 - Placing a hold on a single item from the staff cart causes errors This is caused by the javascript function placeHold() in basket.pl The cause of this error is thus: when a staff member uses the cart to place holds on multiple items at once, the cart redirects to reserver/request.pl with the params 'biblionumbers' ( a string of biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param multi_hold with a value of 1. When multi_hold is enabled, request.pl splits the string 'biblionumbers' on those slashes and works on that list. In placeHold(), when only one item is checked, the system passes the param biblionumbers with a single biblionumber ( e.g. '5/' ) and does *not* pass the multi_hold param. This causes request.pl to not parse the biblionumbers param, and thus reserve.pl has no biblionumber to work on ( hence our error here ). There are two options to resolve this: A) Add the multi_hold param even for a single hold from the cart. B) In the event of a single hold being placed from the cart, switch to the standard single hold url ( i.e. request.pl?biblionumber=234 ) This commit resolves the situation using option B, as it seems more logical than using the multi-holds system for a single hold. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9078|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9079&action=edit Bug 7940 - Placing a hold on a single item from the staff cart causes errors This is caused by the javascript function placeHold() in basket.pl The cause of this error is thus: when a staff member uses the cart to place holds on multiple items at once, the cart redirects to reserver/request.pl with the params 'biblionumbers' ( a string of biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param multi_hold with a value of 1. When multi_hold is enabled, request.pl splits the string 'biblionumbers' on those slashes and works on that list. In placeHold(), when only one item is checked, the system passes the param biblionumbers with a single biblionumber ( e.g. '5/' ) and does *not* pass the multi_hold param. This causes request.pl to not parse the biblionumbers param, and thus reserve.pl has no biblionumber to work on ( hence our error here ). There are two options to resolve this: A) Add the multi_hold param even for a single hold from the cart. B) In the event of a single hold being placed from the cart, switch to the standard single hold url ( i.e. request.pl?biblionumber=234 ) This commit resolves the situation using option B, as it seems more logical than using the multi-holds system for a single hold. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9079|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9095&action=edit Bug 7940 - Placing a hold on a single item from the staff cart causes errors This is caused by the javascript function placeHold() in basket.pl The cause of this error is thus: when a staff member uses the cart to place holds on multiple items at once, the cart redirects to reserver/request.pl with the params 'biblionumbers' ( a string of biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param multi_hold with a value of 1. When multi_hold is enabled, request.pl splits the string 'biblionumbers' on those slashes and works on that list. In placeHold(), when only one item is checked, the system passes the param biblionumbers with a single biblionumber ( e.g. '5/' ) and does *not* pass the multi_hold param. This causes request.pl to not parse the biblionumbers param, and thus reserve.pl has no biblionumber to work on ( hence our error here ). There are two options to resolve this: A) Add the multi_hold param even for a single hold from the cart. B) In the event of a single hold being placed from the cart, switch to the standard single hold url ( i.e. request.pl?biblionumber=234 ) This commit resolves the situation using option B, as it seems more logical than using the multi-holds system for a single hold. Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes tests, works as advertised. Good catch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Javascript-level patch to use different hold placement tool if only a single bib is passed. Looks clean. Removes badBibs variable, but this does not appear to actually be used anywhere in placeHold(), so this is safe. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7940 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org