[Bug 4819] New: Add ID tags to certain areas of OPAC so jquery can be used to hide them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Summary: Add ID tags to certain areas of OPAC so jquery can be used to hide them Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: chris@bigballofwax.co.nz ReportedBy: jwagner@ptfs.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 I've gotten requests to hide various parts of the OPAC screen that don't presently have tags, so it's been hard to do it with jquery. This patch adds tags to three places. * The OPAC search strategy -- some sites don't want to see the actual strategy used to display (e.g., “ mc-itype:BK or mc-itype:CR”), just the count. I added a span surrounding that part of the line, and put the word Search in front. Now the line reads Search “ mc-itype:BK or mc-itype:CR” returned 2235 results. If this jquery is used: $("#strategy").remove(); The line reads Search returned 2235 results. * The OPAC record display -- I've had a couple of requests to turn off the Notes tab. I added a span to it, so that using this jquery: $("#holdingnotes").remove(); hides that tab. * The OPAC patron account messaging tab -- Enhanced Messaging Preferences syspref has to be on for hold notices etc. to get sent out, but if that syspref is on, the Messaging tab shows in the OPAC patron account. Some sites do not want to allow patrons to change the settings. I added a span to that tab, so that using this jquery: $("#showmsgtab").remove(); hides the messaging tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 --- Comment #1 from Jane Wagner <jwagner@ptfs.com> --- Actually, I wrote a patch some time batck to use a syspref to hide the messaging tab -- looks like Bug 3535 hasn't been pushed to head yet. The span label will work in the meantime, if it gets pushed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 --- Comment #2 from Jane Wagner <jwagner@ptfs.com> --- Created attachment 2166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2166 patch file against current head -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ID tags to certain |Add ID attribute to certain |areas of OPAC so jquery can |areas of OPAC so jquery can |be used to hide them |be used to hide them -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |katrin.fischer@bsz-bw.de Component|OPAC |Templates Assignee|chris@bigballofwax.co.nz |oleonard@myacpl.org QA Contact|koha-bugs@lists.koha-commun |koha.sekjal@gmail.com |ity.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The attached patch predates TT and will no longer apply. 'OPAC search strategy' is no longer a problem, as we have decided to generally not show the search terms and indexes but only the result count. Current display: "Your search returned 3119 results." My patch adds an unique id to every item tab and to every column in the items table on the holdings tab. I think the patron account tabs should be checked and dealt with in a separate patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8538&action=edit Bug 4918: Add ids to OPAC detail page Patch adds an unique id to every item tab and to every column in the items table on the holdings tab. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2166|0 |1 is obsolete| | Attachment #8538|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8539&action=edit Bug 4819: Add ids to OPAC detail page Patch adds an unique id to every item tab and to every column in the items table on the holdings tab. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8582&action=edit Bug 4819: Add ids to OPAC detail page Patch adds an unique id to every item tab and to every column in the items table on the holdings tab. http://bugs.koha-community.org/show_bug.cgi?id=4819 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8539|0 |1 is obsolete| | Attachment #8582|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8583&action=edit [SIGNED-OFF] Bug 4819: Add ids to OPAC detail page Patch adds an unique id to every item tab and to every column in the items table on the holdings tab. http://bugs.koha-community.org/show_bug.cgi?id=4819 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This change allows us to use some variation on the following JavaScript: ---- // Hide the "date due" column // identify the header for the column we're hiding var th = $("#item_datedue"); // Get the index of the header cell var ind = $("#holdingst th").index(th); // Indexes are zero-based but ":nth-child" starts at one, so increment ind++; // Hide the table header $(th).hide(); // Hide each table cell within the holdings table which has the same // index as the header cell we identified $('#holdingst td:nth-child('+ind+')').hide(); ---- Place that JS inside a $(document).ready() block in your OPACUserJS system preference to automatically hide the specified column in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- Template only change to add IDs to opac-details.tt. Fixes some indentation for readability. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- patch pushed, with a small conflict solve, please double check -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|rel_3_8 |rel_3_6 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4819 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org