[Bug 40163] New: Several http links should be moved to https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Bug ID: 40163 Summary: Several http links should be moved to https Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org FSF and GNU links should be moved to HTTPS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 183333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183333&action=edit Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I've failed QA as for all the release notes in diff, the existing https was changed to http. A couple of other things noted, but outside the scope of the bug: URLs changed, excluding release notes: - http://www.gnu.org/licenses -> https://www.gnu.org/licenses - http://wiki.koha-community.org/wiki/Shibboleth_Configuration -> https://wiki.koha-community.org/wiki/Shibboleth_Configuration - http://koha-community.org/ -> https://koha-community.org/ - http://bugs.koha-community.org/ -> https://bugs.koha-community.org/ - http://fsf.org/ -> https://fsf.org/ - http://www.gnu.org/licenses/gpl.html -> https://www.gnu.org/licenses/gpl.html - http://bugs.koha-community.org/bugzilla3/ -> https://bugs.koha-community.org/bugzilla3/ - http://wiki.koha-community.org/wiki/Bug7284_authority_matching_improvement -> https://wiki.koha-community.org/wiki/Bug7284_authority_matching_improvement - http://wiki.koha-community.org/wiki/Age_restriction -> https://wiki.koha-community.org/wiki/Age_restriction - http://wiki.koha-community.org/wiki/OpacHiddenItems -> https://wiki.koha-community.org/wiki/OpacHiddenItems - http://wiki.koha-community.org/wiki/SQL_Reports_Library -> https://wiki.koha-community.org/wiki/SQL_Reports_Library - http://wiki.koha-community.org/wiki/Opac_browse_feature -> https://wiki.koha-community.org/wiki/Opac_browse_feature - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2883 -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2883 - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 - http://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format -> https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format Notes: - https://fsf.org/ redirects to https://www.fsf.org/ - http://www.gnu.org/licenses/gpl.html redirects to https://www.gnu.org/licenses/gpl-3.0.html - http://www.w3.org/2001/XMLSchema-instance redirects to https://www.w3.org/2001/XMLSchema-instance . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_006.xml . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_007.xml . koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_008.xml Should https://bugs.koha-community.org/bugzilla3/ be just https://bugs.koha-community.org/ ? - debian/docs/koha-common.xml - debian/docs/koha-create.xml Says licensed under the General Public License, v2 (originally from 2002): - admin/aqbudgetperiods.pl - admin/aqplan.pl - admin/systempreferences.pl - authorities/ysearch.pl - cataloguing/ysearch.pl - tags/review.pl https changed to http for all release notes in the diff: - misc/release_notes/release_notes_17_05_00.html and misc/release_notes/release_notes_17_05_00.md - misc/release_notes/release_notes_18_05_00.html and misc/release_notes/release_notes_18_05_00.md - misc/release_notes/release_notes_20_11_00.html and misc/release_notes/release_notes_20_11_00.md: - misc/release_notes/release_notes_21_05_00.html and misc/release_notes/release_notes_21_05_00.md: - misc/release_notes/release_notes_21_11_00.html and misc/release_notes/release_notes_21_11_00.md - misc/release_notes/release_notes_22_05_00.html and misc/release_notes/release_notes_22_05_00.md - misc/release_notes/release_notes_22_11_00.html and misc/release_notes/release_notes_22_11_00.md - misc/release_notes/release_notes_23_05_00.md - misc/release_notes/release_notes_23_11_00.md - misc/release_notes/release_notes_24_05_00.md - misc/release_notes/release_notes_24_11_00.md - misc/release_notes/release_notes_25_05_00.md -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183333|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186545&action=edit Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186546&action=edit Bug 40163: (follow-up) Fix Bugzilla URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186545|0 |1 is obsolete| | Attachment #186546|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186547&action=edit Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186548&action=edit Bug 40163: (follow-up) Fix Bugzilla URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I decided not to fix the release notes. It is just too much and probably shouldn't even belong to this repository. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186547|0 |1 is obsolete| | --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186623&action=edit Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186548|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186624&action=edit Bug 40163: (follow-up) Fix Bugzilla URL Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- I rebased this when I signed off because /App/Plugin/CGIBinKoha.pm had been deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186623|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186762&action=edit Bug 40163: Fix several http addresses in the code docs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186624|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186763&action=edit Bug 40163: (follow-up) Fix Bugzilla URL Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- /kohadevbox/koha/xt/find-license-problems.t is failing now Is the right fix to update the test to allow for both 'http' and 'https' or find all the occurrences of: # <http://www.gnu.org/licenses> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #15 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #14)
/kohadevbox/koha/xt/find-license-problems.t is failing now
Is the right fix to update the test to allow for both 'http' and 'https' or find all the occurrences of:
Following the spirit of this patches, we should enforce https for the GNU licenses. But I found a few places where my search didn't find some wrong cases. I'll attach a follow-up ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #16 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186890&action=edit Bug 40163: (follow-up) Fix wrong GNU links and update test Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40872 [Bug 40872] opac/unapi type not detected by tidy.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main. Thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41481 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #18 from Andrii Nugged <nugged@gmail.com> --- this patch breaks for example: .../cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_field_008.pl (when you want to use Tag Editor view one field in Marc editor) with pop-up error: Can't validate the xml data from /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/data/marc21_field_008.xml if I remove the change: -<Tagfield tag="008" xmlns="https://koha-community.org" ... +<Tagfield tag="008" xmlns="http://koha-community.org" ... It becomes to work well. I assume it fails on all other .xml plugins. This already came to 25.05-x branch and also in v25.11.00-2 releaseю -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 --- Comment #19 from Andrii Nugged <nugged@gmail.com> --- ah, we have follow-up, Bug 41481. Okay. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.07 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it is in 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 24.11.x (too hard because of tidy) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41498 --- Comment #22 from David Nind <david@davidnind.com> --- Minimal changes required to the manual (if any). Link checking in December updated any issues I could find - http changed to https. See Bug 41498 - Documentation maintenance tasks - December 2025 (and merge request https://gitlab.com/koha-community/koha-manual/-/merge_requests/1157 - commit about link checking). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41481 [Bug 41481] XML validation error when launching the tag editor for MARC21 fields 006/008 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org