[Bug 20053] New: Drop type attribute "text/javascript" used in OPAC template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Bug ID: 20053 Summary: Drop type attribute "text/javascript" used in OPAC template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: indradg@l2c2.co.in QA Contact: testopia@bugs.koha-community.org If you run the Koha OPAC pages through the W3C validator it generates warnings about type attribute "text/javascript", since W3C now officially describes this as obsolete in HTML5 but still conforming to the standard with warnings [1] Since we are already pumping up HTML5 with <!DOCTYPE html>, I was thinking if we should consider an omnibus update to the following 47 templates so affected. The 47 templates: includes/calendar.inc includes/columns_settings.inc includes/datatables.inc includes/doc-head-close.inc includes/greybox.inc includes/opac-bottom.inc includes/password_check.inc includes/slip-print.inc modules/clubs/clubs-tab.tt modules/clubs/enroll.tt modules/opac-account.tt modules/opac-advsearch.tt modules/opac-auth-detail.tt modules/opac-auth-MARCdetail.tt modules/opac-auth.tt modules/opac-basket.tt modules/opac-course-details.tt modules/opac-course-reserves.tt modules/opac-detail.tt modules/opac-downloadshelf.tt modules/opac-full-serial-issues.tt modules/opac-idref.tt modules/opac-illrequests.tt modules/opac-imageviewer.tt modules/opac-MARCdetail.tt modules/opac-memberentry.tt modules/opac-messaging.tt modules/opac-overdrive-search.tt modules/opac-passwd.tt modules/opac-password-recovery.tt modules/opac-readingrecord.tt modules/opac-request-article.tt modules/opac-reserve.tt modules/opac-results-grouped.tt modules/opac-results.tt modules/opac-review.tt modules/opac-search-history.tt modules/opac-shareshelf.tt modules/opac-shelves.tt modules/opac-showreviews.tt modules/opac-suggestions.tt modules/opac-tags.tt modules/opac-topissues.tt modules/opac-user.tt modules/sco/help.tt modules/sco/printslip.tt modules/sco/sco-main.tt Reference: [1] https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-ob... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |indradg@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #1 from Indranil Das Gupta <indradg@l2c2.co.in> --- Created attachment 70786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70786&action=edit Bug 20053 - Drop type attribute "text/javascript" in OPAC templates Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop type attribute |Drop type attribute |"text/javascript" used in |"text/javascript" for |OPAC template |<script> elements used in | |OPAC templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20054 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70786|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70794&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> The QA tool raises some warnings, but these are about issues which pre-date this patch. They should be addressed in a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prevents warnings about release notes| |type attribute being | |generated for <script> | |elements when testing the | |OPAC pages using W3C | |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20066 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 [Bug 20066] Remove forbidden patterns from .inc and .tt files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #3 from Indranil Das Gupta <indradg@l2c2.co.in> --- @Owen: I've added the fix for the forbidden patterns detected by qa tools in a separate patch as you had suggested i.e. Bug 20066. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70794|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71024&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> The QA tool raises some warnings, but these are about issues which pre-date this patch. They should be addressed in a separate bug. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71025&action=edit Bug 20053: (QA follow-up) Also drop language attribute in OPAC templates Only one occurence in opac-password-recovery.tt Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about the staff interface? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
What about the staff interface?
The staff client templates should be similarly modified, but with so many "move template javascript to the footer" patches in various stages of QA I think it should wait. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Indranil, the patch does not longer apply, can you rebase? It sounds like it would be better to regenerate it, I guess you wrote a small script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #9 from Indranil Das Gupta <indradg@l2c2.co.in> --- I will get to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71024|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74946&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates This patch is a reimplementation of the original from Indranil Das Gupta and the QA follow-up from Julian Maurice. Original test plan: Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74946|0 |1 is obsolete| | --- Comment #11 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 75781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75781&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates This patch is a reimplementation of the original from Indranil Das Gupta and the QA follow-up from Julian Maurice. Original test plan: Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75781|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75783&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates This patch is a reimplementation of the original from Indranil Das Gupta and the QA follow-up from Julian Maurice. Original test plan: Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Too much conflicts in 17.11.x. Since its not critical, I choose not to backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prevents warnings about |Prevents warnings about release notes|type attribute being |type attribute being |generated for <script> |generated for `<script>` |elements when testing the |elements when testing the |OPAC pages using W3C |OPAC pages using W3C |Validator for HTML5. |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prevents warnings about |Prevents warnings about release notes|type attribute being |type attribute being |generated for `<script>` |generated for `script` |elements when testing the |elements when testing the |OPAC pages using W3C |OPAC pages using W3C |Validator for HTML5. |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop type attribute |Drop type attribute |"text/javascript" for |"text/javascript" for |<script> elements used in |*script* elements used in |OPAC templates |OPAC templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop type attribute |Drop type attribute |"text/javascript" for |"text/javascript" for |*script* elements used in |`<script>` elements used in |OPAC templates |OPAC templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prevents warnings about |Prevents warnings about release notes|type attribute being |type attribute being |generated for `script` |generated for `<script>` |elements when testing the |elements when testing the |OPAC pages using W3C |OPAC pages using W3C |Validator for HTML5. |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Ahhhh so this led to a QA change that would block us from using type="module". Hmmmm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #16)
Ahhhh so this led to a QA change that would block us from using type="module". Hmmmm
Actually nevermind. I think it looks specifically for type="text/javascript". The error message is just incorrect... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org