http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Cab Vinton <director@plaistowlibrary.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director@plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just looking for a new placeholder. We got <<items.fine>> to display the fine per item. And we have something like <<today>> to display today's date. The suggestion would be to have something like <<totalfine>> or similar to print the total amount owed by a patron in the letter. So a single placeholder - not one to be repeated in the letter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #4 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41872&action=edit Bug 13961: Option to include patron's total amount of fines in notices Possibility to show patrons's total amount of fines in notices. Test plan: 1. Apply patch 2. Modify some notice in Tools -> notices & slips 3. See that in the left side of where one can edit message's body is now also a new attribute that one can include to the text: borrowers.totalfine 4. Include that to the text and see it showing the patron's total amount of fines. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- Works as expected. However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 42077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42077&action=edit Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi Joonas, There are some space chars in an empty line, see screenshot from diff view. Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #9 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Joonas Kylmälä from comment #8)

(In reply to Marc Véron from comment #7)

...

Created attachment 42077 [details] Screenshot from diff view - white chars in empty line 648 in C4/letters.pm

Hi Joonas,

There are some space chars in an empty line, see screenshot from diff view.

Marc

When I apply the patch and try to edit with Gedit, Atom, Nano none of these editors see the whitespace. Can you please make a follow-up where you remove it because I'm not able to.

I think the problem is with the bugzilla's diff shower because in my patch I didn't even modify that line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.