[Bug 9004] New: Talking Tech doesn't account for holidays when calculating a holds last pickup date.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Priority: P5 - low Change sponsored?: --- Bug ID: 9004 Assignee: koha-bugs@lists.koha-community.org Summary: Talking Tech doesn't account for holidays when calculating a holds last pickup date. Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha The Talking Tech outbound script adds the ReservesMaxPickUpDelay to the waitingdate of a reserve to calculate its last pickup day. However, this day may fall on a holiday. In this case, the last day to pick the item up should be pushed to the next open day. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13176&action=edit Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I perltidy'ed the file which has obscured my changes. The only non-formatting change is at lines 296-298. It just checks to see if the pickup date is a holiday, and if it is loops day by day until if finds the next open day for that library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #2)
I perltidy'ed the file which has obscured my changes. The only non-formatting change is at lines 296-298. It just checks to see if the pickup date is a holiday, and if it is loops day by day until if finds the next open day for that library.
Could you please break this into two patches? Either order is fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13176|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13212&action=edit Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Perltidy script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13213&action=edit Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Add holidays check -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> ---
Could you please break this into two patches? Either order is fine.
No problem! Again, the main change is the addition of the loop starting at line 295. I also switched from using arrays for the date parts to named variables, in the interest of self-documenting code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- How is this going to get tested? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Depends on| |8735, 8367 --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- I'm adding dependencies on two other bugs concerned with adjusting the max pickup date for holidays. The bugs are interlinked in a somewhat tangled way. As it would be awkward if the iTiva export, the hold expiration cronjob, and the hold display were to have different notions of exactly when a waiting hold has sat on the shelf too long, any final patches for all three bugs will almost certainly be pushed as a unit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 8367 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #10 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 8367 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-24 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 8367 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #12 from I'm just a bot <gitbot@bugs.koha-community.org> --- This bug depends on 8367 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Setting status to BLOCKED since this patch depends on two patches that do not apply resp. failed qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8367 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8367 Depends on| |8367 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8367 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #14 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Kyle M Hall from comment #5)
Created attachment 13213 [details] [review] Bug 9004 - Talking Tech doesn't account for holidays when calculating a holds last pickup date - Add holidays check
Code looks good to me but I'm unable to test this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org