[Bug 19972] New: Holds to pull (pendingreserves.pl) should honor syspref " item-level_itypes"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Bug ID: 19972 Summary: Holds to pull (pendingreserves.pl) should honor syspref "item-level_itypes" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70549&action=edit Bug 19972: pendingreserves.pl now honors syspref "item-level_itypes" And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Lucie Gay <lucie.gay@ens-paris-saclay.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72804&action=edit Bug 19972: pendingreserves.pl now honors syspref "item-level_itypes" And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Maybe type-filter is not the best of names? This filter currently works a bit weird, and also with your patch. If a biblio has two items of a different type, I see two item types on one line in the dropdown. Can we fix it here or is it already out of scope? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Marcel de Rooy from comment #4)
Maybe type-filter is not the best of names?
Which name can I use to replace it?
This filter currently works a bit weird, and also with your patch. If a biblio has two items of a different type, I see two item types on one line in the dropdown. Can we fix it here or is it already out of scope?
I must be a followup patch anyway (already signed off) so can it be another bugzilla? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to pull |Holds to pull should honor |(pendingreserves.pl) should |syspref "item-level_itypes" |honor syspref | |"item-level_itypes" | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72804|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74706&action=edit Bug 19972: Make holds to pull list honors item-level_itypes syspref And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74707&action=edit Bug 19972: (QA follow-up) Fix id name Renames #type-filter to #itemtype-filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Victor, please file another bug for the problem with the datatables filter, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20637 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #9 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Created attachment 74707 [details] [review] Bug 19972: (QA follow-up) Fix id name
Renames #type-filter to #itemtype-filter
Thanks, I didn't dare to name it itemtype or itype because it can actually be both. So I though it would be confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #9)
(In reply to Katrin Fischer from comment #7)
Created attachment 74707 [details] [review] [review] Bug 19972: (QA follow-up) Fix id name
Renames #type-filter to #itemtype-filter
Thanks, I didn't dare to name it itemtype or itype because it can actually be both. So I though it would be confusing.
I wouldn't overthink the name. I think not naming them the same was just a historical QA oversight. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74706|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 74878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74878&action=edit Bug 19972: Make holds to pull list honors item-level_itypes syspref And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74707|0 |1 is obsolete| | --- Comment #12 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 74879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74879&action=edit Bug 19972: (QA follow-up) Fix id name Renames #type-filter to #itemtype-filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #13 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- - rebased and solved a conflict - retried the test plan - did a diff between the previous patches file; to check that the rebased didn't impacted the actual changes; and confirm that a new sign off should be required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #15 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Oups, I should have wrote «and confirm that a new sign off should **not** be required» Thanks Jonathan for still understanding ^^ and having moved the patch forward! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.07. Easy rebase conflict because JS has moved to bottom. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org