[Bug 38954] New: checkout type column should be hidden by colvis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Bug ID: 38954 Summary: checkout type column should be hidden by colvis Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There is a "shift" in the checkout history table (readingrec) https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg The table should take the whole available width -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38783 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176946&action=edit Bug 38954: Hide checkout type using colvis This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176946|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 177073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177073&action=edit Bug 38954: Hide checkout type using colvis This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 177075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177075&action=edit Screenshot - Type column value is system value, not a human-readable value I've signed off, but I had to apply bug 38783 first, otherwise I got a sha1/fake ancestor error. I've added it as a dependency. Also, there is now a new "Type" column displayed by default. For normal checkouts, the value shown is "standard_checkout" (see the screenshot). Shouldn't this display as a "human-readable" value, rather than a system value? Such as "Standard checkout", and for other types of checkouts (which I didn't test). I do really like the improved layout and the pill "button", it is very much improved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38793 [Bug 38793] Transfer silently not canceled when TransfersBlockCirc = "don't block" and AutomaticConfirmTransfer = "do automatically confirm" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- You should not see the "Type" column. Did you restart_all after you applied the patches? Also maybe you need to remove your localStorage entries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Depends on|38793 |38783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 [Bug 38783] Row highlighting in table_readingrec members/readingrec.pl doesn't look great https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38793 [Bug 38793] Transfer silently not canceled when TransfersBlockCirc = "don't block" and AutomaticConfirmTransfer = "do automatically confirm" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #4)
You should not see the "Type" column. Did you restart_all after you applied the patches? Also maybe you need to remove your localStorage entries.
Apologies for the noise - that was it! Now working as expected. (I normally start with a fresh browser with a cleared cache after applying a patch. For some reason, I forgot to do this...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177073|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177100&action=edit Bug 38954: Hide checkout type using colvis This is not the correct way to hide a column, we should use the DT's column visibility plugin. Test plan: Have some checkouts for a patron, go to the checkout history page Without this patch notice the "shift" => the table does not take the whole available width. Apply this patch, restart_all, remove localStorage entries => The table is now displayed properly You can also play with on-site checkouts. Before: https://snipboard.io/uTWYit.jpg https://snipboard.io/qxZE35.jpg After: https://snipboard.io/2L0F3Q.jpg Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- It looks like the yaml updates are not in main. The column is now visible, due to the .tt changes but it's not being hidden in the .yml file. 1449 checkouthistory: 1450 checkouthistory-table: 1451 default_display_length: 20 1452 columns: 1453 - columnname: type 1454 cannot_be_toggled: 1 1455 cannot_be_modified: 1 1456 - -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40281 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Laura Escamilla from comment #9)
It looks like the yaml updates are not in main. The column is now visible, due to the .tt changes but it's not being hidden in the .yml file.
1449 checkouthistory: 1450 checkouthistory-table: 1451 default_display_length: 20 1452 columns: 1453 - columnname: type 1454 cannot_be_toggled: 1 1455 cannot_be_modified: 1 1456 -
Can confirm. It looks like the change was inadvertantly reversed by Bug 37273: Added ID column to ERM Agreements and Licenses Tables. The weird thing is that I can't see it in the diffs on the bug, but the change was made in the actual commit https://git.koha-community.org/Koha-community/Koha/commit/d361c8adb6ffc5b269... I've created Bug 40281 - Patron circulation history page - type column is not hidden, and added a patch, ready for sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40299 [Bug 40299] Regression - checkout type column still visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 [Bug 40281] Patron circulation history page - type column is not hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org