[Bug 40281] New: Patron circulation history page - type column is not hidden
Circulation hstory), and note that there is a 'Type' column shown with a value of 'standard_checkout'.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Bug ID: 40281 Summary: Patron circulation history page - type column is not hidden Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com For a patron's circulation history page, the 'Type' column should be hidden, but it isn't. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. I can't see the change in the diffs on the bug, but the change was made in the actual commit https://git.koha-community.org/Koha-community/Koha/commit/d361c8adb6ffc5b269... To replicate: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38954, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37273 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
Circulation history), and note there is a 'Type' column shown with a value of 'standard_checkout'.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 183650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183650&action=edit Bug 40281: Hide the type column on the patron circulation history page This fixes the patron circulation history page so that the type column is hidden. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. Test plan: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table. 4. Apply the patch, restart everything (restart_all), and clear your browser cache. 5. Repeat step 2. Note that there is now no 'Type' column shown and it is not configurable, from either selecting the 'Columns' or 'Configure' options for the table. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate Patch complexity|--- |Trivial patch Text to go in the| |This fixes the patron release notes| |circulation history page. | |The 'Type' column should | |not be shown, and is now | |hidden. -- You are receiving this mail because: You are watching all bug changes.
Circulation history), and note there is a 'Type' column shown with a value of 'standard_checkout'.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183650|0 |1 is obsolete| | --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 183658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183658&action=edit Bug 40281: Hide the type column on the patron circulation history page This fixes the patron circulation history page so that the type column is hidden. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. Test plan: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table. 4. Apply the patch, restart everything (restart_all), and clear your browser cache. 5. Repeat step 2. Note that there is now no 'Type' column shown and it is not configurable, from either selecting the 'Columns' or 'Configure' options for the table. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Thank you for working on this so quickly! The patch is simple, the qa tool is happy, I'm going to jump this over to passed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Depends on| |37273, 38954 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Please link to the bugs so those bugfixes can be found easily :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 [Bug 37273] Add ID column to Agreements table in the ERM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 [Bug 38954] checkout type column should be hidden by colvis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 40299 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40301 [Bug 40301] Missing Cypress tests for 'Type' column visibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 37273 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- Bug fix. No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #10 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- This column appears to be back in 25.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 Bug 40281 depends on bug 38954, which changed state. Bug 38954 Summary: checkout type column should be hidden by colvis https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38954 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org