[Bug 35769] New: Untranslatable string in requeste.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Bug ID: 35769 Summary: Untranslatable string in requeste.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: anneli.osterman@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Created attachment 160797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160797&action=edit Screenshot of the untranslatable pop up There is a untranslatable string In requeste.tt: "Please make sure all selected titles have a pickup location set" (line 1552). See the attachment. The string shows up when you are making a multi-hold and leave one of the titles without pick-up place and then try to save the holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 35770 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Summary|Untranslatable string in |Untranslatable strings when |requeste.tt |placing holds in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |I18N/L10N CC| |frederic@tamil.fr, | |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 161011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161011&action=edit Bug 35769: Fix untranslatable strings in request.tt This fixes some strings in the JavaScript part of the template that were missing from the po files. This is one way to test: * Apply patch * Run gulp po:update --lang <language-code> * Compare strings changed in the patch, with strings appearing in <language-code>-staff-prog.po * Translate the strings and remove "fuzzy" line * In k-t-d, run: sudo koha-translate --install <language-code> --dev <instance> * Verify that now the translated version of the template contains your translated strings * Verify the translated page works correctly, no errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think you have extra parenthesis: msg = (_("- Please select a pickup location for the item") + "\n"); should be msg = _("- Please select a pickup location for the item") + "\n"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know, but the strings weren't picked up for translation before I added them. I copied from another place in the file where it worked. Do you see why else this did not work before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161011|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 161222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161222&action=edit Bug 35769: Fix untranslatable strings in request.tt This fixes some strings in the JavaScript part of the template that were missing from the po files. This is one way to test: * Apply patch * Run gulp po:update --lang <language-code> * Compare strings changed in the patch, with strings appearing in <language-code>-staff-prog.po * Translate the strings and remove "fuzzy" line * In k-t-d, run: sudo koha-translate --install <language-code> --dev <instance> * Verify that now the translated version of the template contains your translated strings * Verify the translated page works correctly, no errors Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Replicate the issue: 1.1 Install another language: sudo koha-translate --install <language-code> --dev <instance> (sudo koha-translate --install fr-CA --dev kohadev) 1.2 Enable the language in the staff interface: Administration > System preferences > I18N/L10N > language > select the language you installed (for example: Français (fr-CA)) > Save all I18N/L10N... 1.3 Check the <language-code>-staff-prog.po file for these phrases (in misc/translator/po directory) - they are not found: - Please select a pickup location for the item - Please select a pickup location for this hold - Please make sure all selected titles have a pickup location set - Please select at least one title 1.4 Change the staff interface to the language you have installed 1.5 Perform actions that generate the messages and note that they are in English: - Please make sure all selected titles have a pickup location set: . Perform a search that returns multiple results . Select several of the results and then click the 'Place hold' button . Enter a patron and for the hold screen make sure the pickup location is empty, and click 'Place hold' . Pop up message is not translated and is still in English - Not sure how to generate the other ones 2. Apply the patch. 3. Update the translations: gulp po:update --lang <language-code> (gulp po:update --lang fr-CA) 4. Compare the strings changed in the patch (see step 1.3), with strings appearing in <language-code>-staff-prog.po - they should all now be found in the file. 5. Add a translation for the strings and remove the "fuzzy" line. 6. Update the language: sudo koha-translate --update <language-code> --dev <instance> (sudo koha-translate --install fr-CA --dev kohadev) 7. Repeat step 1.5 - verify that the translated content is now used. 8. Verify that the translated page works correctly, and that there are no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161222|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161312&action=edit Bug 35769: Fix untranslatable strings in request.tt This fixes some strings in the JavaScript part of the template that were missing from the po files. This is one way to test: * Apply patch * Run gulp po:update --lang <language-code> * Compare strings changed in the patch, with strings appearing in <language-code>-staff-prog.po * Translate the strings and remove "fuzzy" line * In k-t-d, run: sudo koha-translate --install <language-code> --dev <instance> * Verify that now the translated version of the template contains your translated strings * Verify the translated page works correctly, no errors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #3)
I think you have extra parenthesis:
msg = (_("- Please select a pickup location for the item") + "\n");
should be
msg = _("- Please select a pickup location for the item") + "\n";
At first I thought the same, but they don't appear to cause a problem in reality.. it's weird.. but it works. I'm passing QA, but I'd love to understand better why that's the case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #8)
(In reply to Jonathan Druart from comment #3)
I think you have extra parenthesis:
msg = (_("- Please select a pickup location for the item") + "\n");
should be
msg = _("- Please select a pickup location for the item") + "\n";
At first I thought the same, but they don't appear to cause a problem in reality.. it's weird.. but it works.
I'm passing QA, but I'd love to understand better why that's the case.
I have to admit, I found this through trial and error and would like to understand better as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161346&action=edit Bug 35769: Remove extra parenthesis -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #4)
I know, but the strings weren't picked up for translation before I added them. I copied from another place in the file where it worked.
Do you see why else this did not work before?
This is working for me. Please try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like this is still under consideration. Changing status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Bumping back into the QA queue.. hoping someone with a little more translation structure knowledge can pick it off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Sending to Katrin's. We were waiting for her. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry missing the time :( If someone has a moment before me, happy to turn this over. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sometimes it's good to come back a bit later, I see what I missed before now. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some strings release notes| |that were not made | |available for translating | |for holds in the staff | |interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35769 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #20 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org