[Bug 37787] New: Undocument koha-worker --queue elastic_index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Bug ID: 37787 Summary: Undocument koha-worker --queue elastic_index Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Documentation for koha-worker --queue elastic_index was added in Bug 36009, and as far as I can tell, that was the right thing to do at the time. Then koha-es-indexer was added in Bug 33108, and after that running both koha-es-indexer and "koha-worker --queue elastic_index" at the same time leads to problems, like only every other elastic_index job getting processed. We should remove the mention of "--queue elastic_index" from the koha-worker docs. (And maybe add a note that only koha-es-indexer should be run.) koha-es-indexer has been introduced to 23.05.00 and 22.11.06, so a fix should not be backported to older versions than that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 170900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170900&action=edit Bug 37787; Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- The POD for https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/work... still mentions elastic_index: =item B<--queue> Repeatable. Give the job queues this worker will process. The different values available are: default long_tasks elastic_index -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 171046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171046&action=edit Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171046|0 |1 is obsolete| | --- Comment #4 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171280&action=edit Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170900|0 |1 is obsolete| | --- Comment #5 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171281&action=edit Bug 37787; Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171280|0 |1 is obsolete| | --- Comment #6 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171282&action=edit Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sukhmandeep.benipal@inLibro | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171281|0 |1 is obsolete| | Attachment #171282|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173164&action=edit Bug 37787: Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173165&action=edit Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32594 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32594 [Bug 32594] Add a dedicated ES indexing background worker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the release notes| |documentation for the | |koha-worker script. It | |removes the elastic_index | |queue from the script, as | |this is now handled by | |koha-es-indexer (added by | |bug 33108 to Koha 23.05.00 | |and backported to | |22.11.06). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37787 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |jesse@bywatersolutions.com --- Comment #12 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org