http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18431&action=edit Bug 10363: DB Changes: Adds a unique key for the authorised values table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4) Srdjan,

I'm not sure if there's a consensus re constructors in the Koha namespace and use of Class::Accessor. I believe it is rarely necessary to provide new() in those cases.

Class:Accessor is already used in many places in the Koha namespace.

I suggest: * remove new() constructors all together, Koha::AuthorisedValue->new({av => $av}) is unnecessary cause it is equivalent to Koha::AuthorisedValue->new($av}

The Koha::AuthorisedValue->new can be called directly with the $av (which contains all values) or just with an id or category/value. These different ways to build an object forced me to have a "new" routine. But maybe I don't see concretely what you say :-/

* upgrade fetch(key) to constructors, passing the key values; this way Koha::AuthorisedValues->new() becomes Koha::AuthorisedValues->fetch()

Yes but, like as before, sometimes we don't want to do a select in DB (when the object is called from Koha::AuthorisedValues).

* if you need to reload(), make those methods, and make reload() and fetch() call _fetch(key)

I think I don't have the need to reload.

In general, has there been a discussion on using DBIx::Class or similar?

Yes, but it seems that nobody strongly supports the integration into Koha. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18430|0 |1 is obsolete| | Attachment #18431|0 |1 is obsolete| | Attachment #18432|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18751&action=edit Bug 10363: Add 2 packages for authorised values Currently, the authorised values are anarchically managed :) We have to have a better way to manage them. I propose 2 packages in order to execute the sql queries into a package instead of directly into the pl script. This development adds: - A new unique key (category and authorised values) for the authorised_values table. - 2 new packages Koha::AuthorisedValue and Koha::AuthorisedValues - 1 new unit test file in order to test these 2 packages. It is a code source evolution, but there is no change for the final user. Test plan: 1/ Apply the patches 2/ Check that existing authorised values is displayed on your admin page (admin/authorised_values.pl). 3/ Update an existing one 4/ Create a new category 5/ Create a new AV for this category 6/ Create another one with the same value, an error should be occur. 7/ Delete one AV. 8/ Click everywhere on the authorised values admin page and try to find a bug. 9/ Launch t/db_dependent/AuthorisedValues.t and check that all tests pass (1 sql error appears, it is normal). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18753&action=edit Bug 10363: Adds unit tests for Koha::AuthorisedValue[s] packages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #9)

Hm, as there is some progress on DBIX integration now, I think it might be worth to put some more thought into this. Putting this "In Discussion" to get some more opinions.

Katrin, Even if someone uses DBIx for authorised values, I think this patch is useful, it refactores dirty code in admin/authorised_values.pl and adds unit tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #9)

Hm, as there is some progress on DBIX integration now, I think it might be worth to put some more thought into this. Putting this "In Discussion" to get some more opinions.

It appears that no opinion comes, so must this patch be lost in the hole of the discussion status? I would prefer to change the status in order to others developers see it on the bugs list. I worked some hours on this refactoring and, as I already said, even if someone wants to write a package using DBIx for authorised values this patch will help him/her! I added unit tests to the new package, I clarified a lot of dirty code: I don't understand the goal to block this patch in discussion for a long time. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I didn't intend to block it for a long time - just seeking out opinions. Maybe 'adding new modules' could be discussed next Tuesday? I have filed a bug for categorie.pl yesterday - which also needs a new module. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-05 last check this| | --- Comment #16 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18752|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21834&action=edit [SIGNED-OFF] Bug 10363: DB Changes: Adds a unique key for the authorised values table. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20729|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21836&action=edit [SIGNED-OFF] Bug 10363: UT: execute tests into a transaction Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11019 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25285&action=edit Bug 10363: DB Changes: Adds a unique key for the authorised values table. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25287&action=edit Bug 10363: UT: execute tests into a transaction Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- [Preliminary] QA Comment: First, compliments to Jonathan for his work in getting the code more organized. This report has been pending for some time already in the queue. Several people (including myself) may have been somewhat hesistant to give comments here. I hope to trigger some discussion again in order to get this report further. Somehow I am not completely happy with the proposed design: two objects for 1) one authorized value and 2) several ones. It got me thinking: Do we really need the singular object? Should we focus to category or collection? And referring to an earlier comment, if we would have DBIC in-between, what still is the additional value of what we have now? Again referring to above (and as a general remark), it is confusing that we already have three or more ways to define objects in the new Koha namespace. You choose for Class:Accessor, but with a lot of additional handwork (blessing, SUPER:: calls, etc.) Somehow the current design makes the impression that the choice for OO here was not so obvious. See also earlier discussion on the new constructor. Why should your object have a fetch method, etc.? (Similar questions for e.g. a filter or all method.) Glancing at the branches_limitation related code in class and script, I wonder if your object(s) should expose that as is done currently. Just stimulating your thoughts about improving design again :) As a preliminary conclusion, I think this needs some more discussion and I would not recommend to move these modules to the Koha folder in the current form (design and DBIC argument-wise). But I would not oppose to move them to C4 (as a compromise) and use them as base for improvement from there. What do others think? Changing status to trigger some discussion. (Jonathan: Feel free to ask the dev list for feedback.) Will try to attract the attention from Galen too.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hello Marcel, Thank you very much for your attention on these patches. The 2 packages are certainly not perfect but they group the code related to AV and add unit tests. And even if DBIx::Class is coming, this refactoring will make easier its utilisation for AV. When a patch improves current code (especially when it's refactoring) and does not introduce regression, I think it is enough to let it go ahead. As I already said, I developped them on my spare time. I don't plan to spend more time for a rewrite. If a further need on this refactoring is small, I will, of course, provide follow-ups, but I won't rewrite them. That's why, I remove myself from the assignee. Please don't see any offense in this answer, I really appreciated your constructive comment! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9967 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Large patch |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25285|0 |1 is obsolete| | --- Comment #30 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 30584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30584&action=edit Bug 10363: DB Changes: Adds a unique key for the authorised values table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yohann.dufour@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30583|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30710&action=edit [SIGNED-OFF] Bug 10363: Adds unit tests for Koha::AuthorisedValue package Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With all patches applied, test pass. No koha-qa errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30585|0 |1 is obsolete| | --- Comment #35 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30712&action=edit [SIGNED-OFF] Bug 10363: Add a package for authorised values Currently, the authorised values are anarchically managed :) We have to have a better way to manage them. I propose a package in order to execute the sql queries into a package instead of directly into the pl script. This development adds: - A new unique key (category and authorised values) for the authorised_values table. - 1 new package Koha::AuthorisedValue - 1 new unit test file in order to test these 2 packages. It is a code source evolution, but there is no change for the final user. Test plan: 1/ Apply the patches 2/ Check that existing authorised values is displayed on your admin page (admin/authorised_values.pl). 3/ Update an existing one 4/ Create a new category 5/ Create a new AV for this category 6/ Create another one with the same value, an error should be occur. 7/ Delete one AV. 8/ Click everywhere on the authorised values admin page and try to find a bug. 9/ Launch t/db_dependent/AuthorisedValues.t and check that all tests pass (1 sql error appears, it is normal). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described following test plan, can't find regressions, can create, update and delete AV and categories Test pass No koha-qa errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #37 from Yohann Dufour <yohann.dufour@biblibre.com> --- I have refactored the work of Jonathan in order to adapt it to the different comments I have read on this bug report. I have tried to find the best compromise between organization, heaviness and simplicity to finally integrate this improvement in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- Just another try: https://git.biblibre.com/biblibre/kohac/commits/ft/bug_10363 wip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32632|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32633&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32633|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32634&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #44 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Kyle M Hall from comment #43)

Created attachment 32634 [details] [review]

I can't apply your patch on a clean Git repo. I get: fatal: sha1 information is lacking or useless (Koha/Object.pm). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #46 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Katrin Fischer from comment #45)

Hi Frederic, did you try to apply bug 13019 first? We are looking for a sign-off on that one, as it's blocking a few things now.

Sorry. My fault. I hadn't noted this bug depends on bug 13019. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32634|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33416&action=edit Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33417|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32634|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33423&action=edit Bug 10363: Use Koha::AuthorisedValue[s] in the admin page Now we have packages, we need use them in the pl script. Test plan: Verify there are no regression on addind/editing/deleting authorised values. Done forget to test the branch limitation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33422|0 |1 is obsolete| | Attachment #33423|0 |1 is obsolete| | --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33860&action=edit [SIGNED-OFF] Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33862&action=edit Bug 10363 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33889&action=edit Bug 10363: Fix pod -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #60 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Fix pod? -Koha::Borrower - Koha Borrower Object class +Koha::AuthorisedValues - Koha Borrower Object set class :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #60)

Fix pod?

At least tried... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33860|0 |1 is obsolete| | Attachment #33861|0 |1 is obsolete| | Attachment #33862|0 |1 is obsolete| | Attachment #33949|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35838&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35840&action=edit Bug 10363 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 13019] There is |There is no package for |no package for authorised |authorised values. |values. | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We just changed the guidelines, I think for old patches already in the QA the old database updates are not a problem at all. Note: this is the form the RM will convert them to anyway. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35838|0 |1 is obsolete| | --- Comment #69 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 41290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41290&action=edit [SIGNED OFF] Bug 10363: There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35840|0 |1 is obsolete| | --- Comment #71 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 41292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41292&action=edit [SIGNED OFF] Bug 10363: [QA Followup] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #73 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 41294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41294&action=edit [SIGNED OFF] Bug 10363: (QA followup) DB update / atomic update This patch just moves the DB update code into an atomicupdate file to avoid nasty merge conflicts. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a bug in there: 1) Create or edit an authorized value 2) Limit to 2+ branches (I had 5) 3) Try to edit the authorized value Software error: Can't use string ("CPL") as a HASH ref while "strict refs" in use at /home/katrin/kohaclone/admin/authorised_values.pl line 63. For help, please send mail to the webmaster (webmaster@bumblebee), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- FWIW, it works perfectly on my local branch, but it is ... 1440 commits behind master... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41343&action=edit Bug 10363: FIX rebase conflict error -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41344|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41345&action=edit Bug 10363: FIX regression - prevent duplicate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14828 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but I still see the duplicate bug - last patch doesn't seem to work? Try changing an existing values description, you will receive: "This authorized value already exists." The change is not saved. Some small note for someone returning to this: I like 'added' better than 'inserted' in the error messages, as it matches the other terminology in Koha better. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14627 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41345|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43112&action=edit Bug 10363: FIX regression - prevent duplicate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43114&action=edit Bug 10363: (follow-up) DB update - change in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43550&action=edit [PASSED QA] Bug 10363: There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43552&action=edit [PASSED QA] Bug 10363: [QA Followup] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43554&action=edit [PASSED QA] Bug 10363: (QA followup) DB update / atomic update This patch just moves the DB update code into an atomicupdate file to avoid nasty merge conflicts. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43556&action=edit [PASSED QA] Bug 10363: FIX rebase conflict error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43558&action=edit [PASSED QA] Bug 13636: Change wording added vs inserted http://bugs.koha-community.org/show_bug.cgi?id=10363 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43114|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|m.de.rooy@rijksmuseum.nl |katrin.fischer@bsz-bw.de --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Over 2 years... but finally! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43696&action=edit Bug 10363: Fix tests The delete op is now "delete" and the confirmation is a JS dialog box. Note that now this patch removes the categories the tests will add (to avoid error on inserting duplicate). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Followup pushed to master. Thanks for taking care, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888 | -- You are receiving this mail because: You are watching all bug changes.