[Bug 14836] New: Move the patron categories related code to Koha::PatronCategories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Bug ID: 14836 Summary: Move the patron categories related code to Koha::PatronCategories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42616&action=edit Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42617&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14828 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14889 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42617|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44059&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44059|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44060&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42616|0 |1 is obsolete| | --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44061&action=edit Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10804 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44060|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44139&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44061|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44140&action=edit Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44141&action=edit Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44142&action=edit Bug 14836: Add tests for Koha::Patron::Categor[y|ies] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44139|0 |1 is obsolete| | Attachment #44140|0 |1 is obsolete| | Attachment #44141|0 |1 is obsolete| | Attachment #44142|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44250&action=edit [PASSED QA] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44250|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44251&action=edit [PASSED QA] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Operations in admin/category is unchanged, and functionnal Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44252&action=edit [PASSED QA] Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44253&action=edit [PASSED QA] Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44254&action=edit [PASSED QA] Bug 14836: Add tests for Koha::Patron::Categor[y|ies] Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44255&action=edit [PASSED QA] Bug 14836 [QA Followup] - Fix number of unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44519&action=edit Bug 14836: (QA followup) Add missing transaction Bug 15081 removed transaction handling from t::lib::TestBuilder so this patchset had to be ammended to handle it on its own. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15379 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15407 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move the patron categories |Move the patron categories |related code to |related code to |Koha::PatronCategories |Koha::Patron::Categories - | |part 1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14828, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14889, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15379 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org