[Bug 23211] New: SIP/Transaction.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Bug ID: 23211 Summary: SIP/Transaction.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 22433 Target Milestone: --- See bug 22433. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433 [Bug 22433] Add debug statements to understand why SIP/Transaction.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The checkout failed because patron's category is the one used for statistics (category_type=X). To recreate the failure: modified: t/db_dependent/SIP/Transaction.t @ Transaction.t:37 @ subtest fill_holds_at_checkout => sub { plan tests => 6; - my $category = $builder->build({ source => 'Category' }); + my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91006&action=edit Bug 23211: Prevent SIP/Transaction.t to fail randomly The checkout failed because patron's category is the one used for statistics (category_type=X). To recreate the failure: modified: t/db_dependent/SIP/Transaction.t @ Transaction.t:37 @ subtest fill_holds_at_checkout => sub { plan tests => 6; - my $category = $builder->build({ source => 'Category' }); + my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Bug 23211 depends on bug 22433, which changed state. Bug 22433 Summary: Add debug statements to understand why SIP/Transaction.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22433 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91006|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 91010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91010&action=edit Bug 23211: Prevent SIP/Transaction.t to fail randomly The checkout failed because patron's category is the one used for statistics (category_type=X). To recreate the failure: modified: t/db_dependent/SIP/Transaction.t @ Transaction.t:37 @ subtest fill_holds_at_checkout => sub { plan tests => 6; - my $category = $builder->build({ source => 'Category' }); + my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as described and causes no regressions.. Thanks Jonathan. Going straight for a PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23211 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org