[Bug 24181] New: Make our datepicker inputs sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Bug ID: 24181 Summary: Make our datepicker inputs sexy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96044&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96045&action=edit Bug 24181: Move the icon back into the input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Before: https://snipboard.io/zOPV4F.jpg After: https://snipboard.io/U4xVrq.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Hey Jonathan, I applied this patch and ran yarn build, it looks sexy in Chrome but not in FF as the calendar icon is doubling up. FireFox: https://snipboard.io/jxb7z6.jpg Chrome: https://snipboard.io/R6bjuS.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Jonathan did you see Bug 23956? I do like the "After" screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96044|0 |1 is obsolete| | Attachment #96045|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96143&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96144&action=edit Bug 24181: Move the icon back into the input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23956 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lucas Gass from comment #4)
Hey Jonathan,
I applied this patch and ran yarn build, it looks sexy in Chrome but not in FF as the calendar icon is doubling up.
FireFox: https://snipboard.io/jxb7z6.jpg Chrome: https://snipboard.io/R6bjuS.jpg
Hi Lucas, I did not recreate, I am using Firefox. Maybe a cache issue? (In reply to Owen Leonard from comment #5)
Jonathan did you see Bug 23956? I do like the "After" screenshot.
I did not! Rebased on top of it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96143|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 96168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96168&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96144|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 96169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96169&action=edit Bug 24181: Move the icon back into the input Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Not sure if it was a caching issue or not, but when I applied both patches and ran yarn build everything looks great so I am signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96168|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96581&action=edit Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96169|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96582&action=edit Bug 24181: Move the icon back into the input Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 [Bug 24363] Datepicker calendar is not sexy on additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The calendar icon in additem looks weird... see bug #24363 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I was going through all the datepickers and found one that is still thinner, in checkexpiration.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Joy Nelson from comment #17)
Pushed to 19.11.x branch for 19.11.02
Hi Joy, there is a lot of issues with this one still - I think it's not fit for stable yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Choosing to skip this enhancement in 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02 |20.05.00 released in| | Status|Pushed to stable |ASSIGNED --- Comment #20 from Joy Nelson <joy@bywatersolutions.com> --- Reverted from 19.11.x branch until more fixes available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Make our datepicker inputs |Improve the display of our |sexy |datepickers -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org