[Bug 28359] New: Invalid value of OpacHiddenItems crashes OPAC search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 Bug ID: 28359 Summary: Invalid value of OpacHiddenItems crashes OPAC search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org 1. put «damaged: 1» in the syspref 2. in OPAC search something that yield at least on result with a least one item 3. error Can't use string ("1") as an ARRAY ref while "strict refs" in use at /kohadevbox/koha/C4/Items.pm line 1012 staff interface search is okay -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Severity|enhancement |normal Component|OPAC |Searching -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28125 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this is invalid with bug 28125. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The about page warning is not likely to be found when hitting the issue. But that can still help. And we have other fish to fry. If somebody wants to make it easier to find the cause the OPAC search crash, they can send a patch here. Anyway, «damaged: 1» doesn't trigger the warning ^^" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24403 CC| |tomascohen@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- filter_by_visible_in_opac and GetHiddenItemnumbers have different behaviours:
From GetHiddenItemnumbers: if (any { $val eq $_ } @{$hidingrules->{$field}}) { Expect an array (damaged: [1])
From filter_by_visible_in_opac: { '-not_in' => $rules->{$field} } will work for array and scalar
GetHiddenItemnumbers must be removed anyway. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is no longer valid since bug 23583. *** This bug has been marked as a duplicate of bug 23583 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28359 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #3)
filter_by_visible_in_opac and GetHiddenItemnumbers have different behaviours:
From GetHiddenItemnumbers: if (any { $val eq $_ } @{$hidingrules->{$field}}) { Expect an array (damaged: [1])
From filter_by_visible_in_opac: { '-not_in' => $rules->{$field} } will work for array and scalar
This is true: it is an unadvertised side-effect of considering the OpacHiddenItems syspref YAML, and not just a subset of YAML. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org