https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make the BarcodeSeparators |Make the OpacHiddenItems be |be a YAML syspref |a YAML syspref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Blocks| |24403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 119222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119222&action=edit Bug 23583: Handle OpacHiddenItems with yaml_preference This patch makes all places in Koha that rely on OpacHiddenItems actually use C4::Context->yaml_preference instead of manually calling the YAML libraries and handling it. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Items* \ t/db_dependent/Koha/Item* \ t/db_dependent/Koha/Filter/EmbedItems.t => SUCCESS: Tests pass! 3. Try hiding things with opac-ISBDdetail.pl and opac-search.pl => SUCCESS: Things work the same! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: - Added withdrawn: [1] to OpacHiddenItems - Changed status of one item for a record with multiple items to Withdrawn . In OPAC the withdrawn item doesn't show in the search results, OPAC detail page or MARC view tab (the ISBD view doesn't show items before or after the patch is applied) - Changed the status to withdrawn for a record that only has one item: . Doesn't show up in the OAPC search results . 404 message if you click on the OPAC view link in from the staff interface details page - Ran tests before and after - all pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119246|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119804&action=edit Bug 23583: Handle OpacHiddenItems with yaml_preference This patch makes all places in Koha that rely on OpacHiddenItems actually use C4::Context->yaml_preference instead of manually calling the YAML libraries and handling it. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Items* \ t/db_dependent/Koha/Item* \ t/db_dependent/Koha/Filter/EmbedItems.t => SUCCESS: Tests pass! 3. Try hiding things with opac-ISBDdetail.pl and opac-search.pl => SUCCESS: Things work the same! 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27673 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23583 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 28359 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.