[Bug 35810] New: Add back to top button on staff result page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Bug ID: 35810 Summary: Add back to top button on staff result page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Hi all, As in bug 30136, I'd like to add a "back to top" button on the search results page. I put the same code as the opac and a bit of css to get a nice result. Feel free to test it and give feedback :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161032&action=edit Bug 35810 : Add back to top button to staff result page Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) Perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30136 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161032|0 |1 is obsolete| | --- Comment #2 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161033&action=edit Bug 35810 : Add back to top button to staff result page Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) Perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161033|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161034&action=edit Bug 35810 : Add back to top button to staff result page Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) Perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161034|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161111&action=edit Bug 35810: Add back to top button to staff result page Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) Perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- This is great! Why not put it in staff-global.js, though? It would be nice to have a back-to-top button on other pages as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161111|0 |1 is obsolete| | --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161882&action=edit Bug 35810: Add back to top button on staff pages Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) For example, perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear Note that it's works also on patron search etc.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add back to top button on |Add back to top button to |staff result page |the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35716 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161882|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161913&action=edit Bug 35810: Add back to top button on staff pages Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) For example, perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear Note that it's works also on patron search etc.. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Putting this back to SO and re-adding Owen's SO line. This looks good although it appears to be out of sync with the work from bug 30136. OPAC button is .btn-primary, whereas this one is .btn-default. OPAC's button has the aria-label and title properties, this button does not. I don't think any of the above are blockers, just pointing it out as it may or may not be intentional. Would be great to have this code DRY (hence adding 35716 as "see also"), but I don't think we're there yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 --- Comment #9 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Thanks Pedro for your feedback. To answer your question about the style .btn-primary would give a style similar to the submit button (yellow) so I opted for a simpler style. Of course, if several opinions are in the same direction, all this can be changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161913|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 162296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162296&action=edit Bug 35810: Add back to top button on staff pages Test plan: 1) Apply this patch and rebuild css with 'yarn build' 2) For example, perform a search from catalogue 3) Scroll down to see the button appear and scroll up to see it disappear Note that it's works also on patron search etc.. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 162298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162298&action=edit Bug 35810: (QA follow-up) Add aria label for accessibility Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA --- Comment #12 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I added a follow-up to give the button an aria-label for accessibility (similar to bug 30136). Otherwise, it looks great, and QA script is happy! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the up icon is showing in the print preview and would end up being printed on every page - could we remove that please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36610 [Bug 36610] Hide "Back to top" when printing pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #13)
It looks like the up icon is showing in the print preview and would end up being printed on every page - could we remove that please?
It looks like the OPAC one will also print into a PDF, I have moved them into a new bug: Bug 36610 - Hide "Back to top" when printing pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 [Bug 30136] Add back to top button when scrolling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a 'back to the release notes| |top' button to the staff | |interface, similar to the | |one in the OPAC, that | |appears in the bottom right | |corner when scrolling down | |on pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org