[Bug 30068] New: Wrong reference to table_borrowers in circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Bug ID: 30068 Summary: Wrong reference to table_borrowers in circulation.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 17353, 21034 There is a reference to table_borrowers in the table settings yaml file, and this: 985 columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] in circulation.tt But #table_borrowers is not a table displaying patrons, but items. The confusion is coming from this commit that first introduced the id on this table: commit 7d598d9130c3d171af1e1a6a0a168cea043c277d Bug 21034: Re-indent circulation.tt Then: commit f6599b2c5480d2e096bac71e4e7ac759686b9fbc Bug 17353: Add phone number column to checkout search That added the columns settings line. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 [Bug 17353] Add phone number column to checkout search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 [Bug 21034] Re-indent circulation.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- olumns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] This is just fetching the settings from the yaml, they are only applied to "#table_borrowers" in circ-patron-search-results.js The table_borrowers that shows items is simply a class on the itemSearchFallBack table - this class is not referenced anywhere so can simply be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm not sure if this is the bug I'm looking for, but I think table_borrowers doesn't refer to any table anymore? It used to be the patron search when searching for a patron for a checkout, but now this search simply falls back to the regular patron search (table is memberresultst). Just to make sure we're talking about the same thing: 1) In the main page of the staff interface, in the search bar at the top, with the tab 'Check out' selected, search for part of a name (e.g. "mar" should give several results with the sample patrons) --> This table used to be table_borrowers, in the past, we could configure it under Administration > Table settings > Circulation --> Note that the tab selected in the search bar at the top is now 'Search patrons' 2) In the main staff interface, in the search bar at the top, with the tab 'Search patrons' selected, search for part of a name --> This table is memberresultst, we can configure it under Administration > Table settings > Patrons Something was consolidated under 'Search patrons', which is fine, but I think the reference to that table under Administration > Table settings > Circulation was forgotten. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Oh I think I found where table_borrowers is used: when searching for a patron to place a hold. So ignore my previous comment! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36614 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164989&action=edit Bug 30068: Remove table_settings_borrowers_table from circulation.tt The history is a mess, but here we init a JS variable that is never used. Test plan: git grep table_settings_borrowers_table should not return anything after this patch applied -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164989|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 165015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165015&action=edit Bug 30068: Remove table_settings_borrowers_table from circulation.tt The history is a mess, but here we init a JS variable that is never used. Test plan: git grep table_settings_borrowers_table should not return anything after this patch applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- oops, forgot the so line... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165015|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 165016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165016&action=edit Bug 30068: Remove table_settings_borrowers_table from circulation.tt The history is a mess, but here we init a JS variable that is never used. Test plan: git grep table_settings_borrowers_table should not return anything after this patch applied Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I also tried a couple of things like searching for patrons and placing a hold and nothing exploded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165016|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165027&action=edit Bug 30068: Remove table_settings_borrowers_table from circulation.tt The history is a mess, but here we init a JS variable that is never used. Test plan: git grep table_settings_borrowers_table should not return anything after this patch applied Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org