http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-02 01:27:39 UTC --- Created attachment 3047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3047 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-14 13:54:38 UTC --- Katrin, chris & me had a strong discussion (by mail) about the proposed behaviour. Chris says Koha should not delete the biblio silently when orders are cancelled (ie: if the librarian has modified the biblio, the deletion can be annoying), I said it can, because it delete only biblio without anymore items, so there's no need to keep the biblio (ie: the booksellers said "can't give you the book" no need to keep it in the catalogue") Can you give your opinion on this question functionnally speaking ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-14 14:09:47 UTC --- I would prefer: Do not delete biblio's when there are items. Warn instead. (Note that we have AcqCreateItem set to cataloging. Normally, there should not be items.) If no items, delete on confirmation. (This could be the first confirmation; in that case the confirmation for deleting an order should be clear about that.) If supplier1 does not have the book, could supplier2 have it? In that case it could be helpful not to delete right-away.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-14 14:23:37 UTC --- I also believe it only deletes the items attached to the order. I had tested with a record that had different items, created from acq and cataloging. Only the acq items were deleted. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-02 08:21:52 UTC --- Yep, all this needs is a follow up patch to check for reserves on the biblio, or subscriptions on the biblio. And then warn the user if this is the case. The scenario of wanting to order the biblio from another supplier was not the one I was concerned about. Its more if a user has placed a hold on it, the hold with either be left dangling or deleted without the user being notified. So not just a confirmation prompt, I want it to check and make sure the biblio has nothing attached to it (another order, a serial subscription a hold etc) and then tell the librarian this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-20 10:44:12 UTC --- +1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3047|0 |1 is obsolete| | --- Comment #11 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-05-25 07:17:38 UTC --- Created attachment 4255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4255 new ment I take this option after a talk with Paul, in the same column (delete) we have now two links : "Delete order" and "Delete order and biblio". If the biblio exists in other orders or if there is any items, in short if we can't delete the biblio, then, this second link does not appear. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 12:55:44 UTC --- Created attachment 4480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4480 screenshot of basket with test cases 1) TYPO: Wording of confirmation message and link Currently: Are you sure you want to delete this order with his biblio ? I am not sure if we should use 'biblio' or better say record. Also 'his' should be 'its'. Suggestion: Are you sure you want to delete this catalog record and order? Both links have long descriptions and are close to each other - but I have no idea, how to improve that for a clearer display. 2) OK: Link to delete order and biblio is only shown, when there are no additional items on the record. Deleting the order only deletes the on order items. 3) PROBLEM: Deleting a record from the order silently deletes subscription attached to that biblio. You can loose a lot of data this way. 4) PROBLEM: One big reason to create items on orders is to enable holds on these items. If you delete a order and biblio with holds on the on order items, the hold is silently deleted. 5) OK: Deleting order, items and biblio with no holds, subscriptions and other items attached to the record. Works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #14 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-09-16 10:24:16 UTC --- Katrin, 1) TYPO: OK, right, sry for my poor english 3) PROBLEM: right I have forforgoten this, I propose to include a test to see if subscription exists. In this case no second link. 4) PROBLEM: it's more complex, I propose to test if there are holds on items in order, and if so, to use notices for emailing to borrower the hold cancelation. I think this option needs to speak about, what is your opinion about my suggest ? Because I think even if we keep biblio we can't keep ghost items, so its better to advise the borrower as we can do when the order is receveid. Waiting suggests. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-07 05:54:28 UTC --- Hi Christophe, can you update on the status? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #18 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-10-09 19:38:17 UTC --- So Katrin, I hope this one is ok, must be tested deeply, because multiple cases. I have taken care of the difference between an hold on catalog record and an hold on a specific item. In some cases you can't delete an order, in other cases you can't delete the order and catalog's record but the order can be deleted. On mouse over you have explanations with count. More, some lines of warnings with count are shown depending of the case. The ergonomy can be discussed, I have chosen these viewing options to have a technical structure steady. Good tests. Waiting your comments. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5813|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-09 22:45:08 UTC --- Created attachment 5816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5816 Bug 5680: Order cancelling improvement : delete attached items & biblio if avalaible - all items attached to the order are deleted - if there is no more items, and if the biblio is not in other orders and no subscriptions and no holds then the biblio is proposed to deletion Now whe have 2 links : "delete order" and "delete order and catalog record", the second one appears only if the deletion is possible. Note that if an hold is related to the item or if the item is unique for the biblio the link "Delete order" is canceled due to hold remaining. On mouse over explanations are shown with count. More lines of warnings with count are shown depending of the case. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Configuration: AcqCreateItem = on order Test cases and results: 1) Order new record with 2 items a) From basket - delete order: only deletes items, OK! - delete order and catalog record: deletes record and items, OK b) From shipment/receive - delete order: only deletes items, OK! 2) Order 1 additional item for existing record with 1 item a) From basket: - delete order: works, existing item and record remain, OK - Can't delete order and catalog record, 1 item left, OK! 3) Order new record with 1 item, title level hold on record a) From basket: - delete order: not possible, OK! - delete orer and catalog record: not possible, OK! b) From shipment/receive page - Cancel: Deletes order, record and hold silently. NO WARNING. NOT OK. See note below. 4) Order 1 additional item for existing record with 1 item, item level hold on existing item a) From basket: - delete order: works, hold and existing item remain, OK! - delete order and catalog record: not possible, OK! b) From shipment/receive page - Cancel: on order item is deleted, other item and hold remain. 5) Order new serial record, create subscription a) From basket: - delete order: works, record and subscription remain, OK! - delete order and catalog record: not possible, OK! b) From shipment/receive page: - Cancel: Subscription and record are silently deleted. NOT OK. 6) Order additional item for existing record with other on order items a) From basket: - delete order: works, existing on order items remain, OK! - delete order and catalog record: not possible, OK! b) From shipment: - Cancel: deletes order and ordered item. OK. Changes made: I changed the wording of the error messages a bit in the template. I changed the message 'Can't delete order and catalog record' to not be shown as a link, as the link does nothing. Tooltip still appears. I attached a screenshot to the bug showing some of my changes. Hope that's ok. Necessary enhancements: Cancelling orders when receiving items should work the same as from the basket summary page. We need the same checks and messages there before deleting records and items automatically. I am signing off on this, but to go into Koha it needs a follow-up for the order receive page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #22 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-10-11 07:32:33 UTC --- Katrin, many thx for your tests. Oups, I have forgotten the basket summary page... I'll work on a follow up. Right, it's better with your changes, visualy it's clearer. So with your help, quite to have something. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #24 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-10-15 20:58:42 UTC --- Hello Katrin, I hope this part is ok. I have created one more column in parcel.pl. Of course it was not the same script, so I hope I haven't forgotten something. Good tests. Thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 05:50:22 UTC --- Created attachment 5914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5914 screenshot of messages on order receive page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 05:53:33 UTC --- Created attachment 5915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5915 screenshot of messages on order receive page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5916|0 |1 is obsolete| | --- Comment #29 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 20:39:34 UTC --- Created attachment 5965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5965 Passed QA followup patch Followup patch passed QA; minor change to template language. Was showing items remaining, but talking about holds remaining, so I made that consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-19 03:59:48 UTC --- Pushed, thank you Katrin and Ian for the good testing, and Christophe for all your hard work writing the card. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7162 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.