[Bug 34616] New: "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Bug ID: 34616 Summary: "Edit SMTP server" page shows unintended dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart+koha@gmail.com, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, nick@bywatersolutions.com, oleonard@myacpl.org, tomascohen@gmail.com Created attachment 154814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154814&action=edit issue To reproduce, on k-t-d: - Add a new SMTP server - Visit the edit page for that SMTP server -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hmm... can't reproduce. Must've been some changing of branches hic-up! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why. Was the intention for this dialog to show above the form? Or should it not display at all? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Owen Leonard from comment #2)
I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why.
Was the intention for this dialog to show above the form? Or should it not display at all?
It's so weird, cause I can't reproduce it intentionally every time. It sometimes happens and other times it doesn't, at least for me! The intention, I believe, is not display at all in that edit form. That dialog should only display in the SMTP servers list page afaik. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34622 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Owen Leonard from comment #2)
I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why.
Was the intention for this dialog to show above the form? Or should it not display at all?
Wait, I stand corrected. It seems this is intended to show on the "is_default" SMTP Server. But the styling seems to have gone crazy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Owen Leonard from comment #2)
I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why.
Was the intention for this dialog to show above the form? Or should it not display at all?
Wait, I stand corrected. It seems this is intended to show on servers that are not tagged as the "is_default" SMTP Server. But the styling seems to have gone crazy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154838&action=edit Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154839&action=edit Bug 34616: Fix showing default server info on edit SMTP server page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154840&action=edit Bug 34616: Move default server info outside the <fieldset> Also DRY current default information dialog block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154838|0 |1 is obsolete| | Attachment #154839|0 |1 is obsolete| | Attachment #154840|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154844&action=edit Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154845&action=edit Bug 34616: Fix showing default server info on edit SMTP server page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154846&action=edit Bug 34616: Move default server info outside the <fieldset> Also DRY current default information dialog block Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Edit SMTP server" page |"Edit SMTP server" page - |shows unintended dialog |Default SMTP configuration | |dialog has some issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154844|0 |1 is obsolete| | Attachment #154845|0 |1 is obsolete| | Attachment #154846|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154960&action=edit Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154961&action=edit Bug 34616: Fix showing default server info on edit SMTP server page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 154962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154962&action=edit Bug 34616: Move default server info outside the <fieldset> Also DRY current default information dialog block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27424 CC| |matt.blenkinsop@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 [Bug 27424] One should be able to assign an SMTP server as the default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Not backporting to 22.11.x - missing dependency 27424 Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34205 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Bug 34616 depends on bug 27424, which changed state. Bug 27424 Summary: One should be able to assign an SMTP server as the default https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org