[Bug 35436] New: Copy is not translatable in OPAC Search History
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Bug ID: 35436 Summary: Copy is not translatable in OPAC Search History Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: adolfo.rodriguez@xercode.es QA Contact: testopia@bugs.koha-community.org Created attachment 159349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159349&action=edit OPAC Search History Capture Copy in the table of OPAC Search History isn't translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 --- Comment #1 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 159350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159350&action=edit Fix - Bug 35436 - Copy is not translatable in OPAC Search History -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- With this patch the responsive behavior of the DataTable is buggy: The last column, which is supposed to be hidden at wider browser widths, is always visible. I notice also that the first column (checkboxes) is sortable. It should not be. Please provide a test plan in your commit message! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159350|0 |1 is obsolete| | --- Comment #3 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 159387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159387&action=edit Fix - Bug 35436 - Copy is not translatable in OPAC Search History The change to the way the table in Search History is handled broke its column definitions, that's why the checkbox column was sortable and the last column was visible when it shouldn't Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159387|0 |1 is obsolete| | --- Comment #4 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 159388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159388&action=edit Fix - Bug 35436 - Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Copy is not translatable in |Copy is not translatable in |OPAC Search History |OPAC search history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Adolfo, I don't see a connection between your patch and the translatability of the string, can you please explain? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 --- Comment #6 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- This is not intuitive. I noticed that in "your checkout history" Copy is translatable unlike in "your search history". I compared the way the table is created and saw that "your checkout history" uses KohaTable so I changed "your search history" to do the same and now Copy gets translated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159388|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159468&action=edit Bug 35436: Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159468|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159663&action=edit Bug 35436: Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.01 |24.05.00,23.11.01,23.05.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org