[Bug 35449] New: Accessibliity: No links on "here"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Bug ID: 35449 Summary: Accessibliity: No links on "here" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org We have some "here" links that slipped into system preference descriptions: Example: UpdateItemLocationOnCheckin <br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibliity: No links on |Accessibility: No links on |"here" |"here" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Is UpdateItemLocationOnCheckin correct? I don't see 'here' in that pref's description. However: kohadev-koha@kohadevbox:preferences(master)$ git grep '>here' opac.pref: - "<br><strong>NOTE:</strong> Library specific JS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>." opac.pref: - "<br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>." The two places I am seeing is OPACUserJS and OPACUserCSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right, copy and paste from a wrong tab. Only the 2 to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159464&action=edit Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159464|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 159481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159481&action=edit Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159481|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159665&action=edit Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org