[Bug 21930] New: Typo in the manage_circ_rules_from_any_libraries description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Bug ID: 21930 Summary: Typo in the manage_circ_rules_from_any_libraries description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Remove the "the" in the description If not set the logged in user could only edit circulation rules for its *the* own library (please note that manage_circ_rules is still required) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd also rephrase it a bit, suggestion: any libraries = any library from its own library = their own library Manage circulation rules form any library. If not set the logged in user can only edit circulation rules from their own library (please note that manage_circ_rules is still required). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jke0429@stacmail.net Assignee|koha-bugs@lists.koha-commun |jke0429@stacmail.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 --- Comment #2 from Jack <jke0429@stacmail.net> --- Created attachment 83930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83930&action=edit BUG 21930: Reworded message on permissions.inc 1. Go to patrons account, more, Set Permissions. 2. Dropdown the Parameters section. 3. Text should display "If not set the logged in user could only edit circulation rules for its the own library (please note that manage_circ_rules is still required)" 4. Apply patch and reload page 5. Text should now display "Edit circulation rules from any library. If not set the logged in user could only edit circulation rules for their own library (please note that manage_circ_rules is still required)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- To check the current and updated wording: 1. Go to the Patrons screen 2. Search or browse for a patron 3. Click on the link for the patron's name in the Name column (result: should end on the details screen for the patron) 4. From the buttons above the patron name select More > Set permissions 5. Expand the list of options under (parameters) Manage Koha system settings (Administration panel) (Note: I've only added this as I'm not familiar with the patrons area and it took me ages to find where this was ...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 --- Comment #4 from David Nind <david@davidnind.com> --- Note: I prefer Katrin's wording, but I don't know whether I understand what exactly is required for the wording, except to remove 'the': "Manage circulation rules from any library. If not set the logged in user can only edit circulation rules from their own library (please note that manage_circ_rules is still required)." Should 'from' in both occurences be 'for'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83930|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 83942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83942&action=edit BUG 21930: Reworded message on permissions.inc 1. Go to patrons account, more, Set Permissions. 2. Dropdown the Parameters section. 3. Text should display "If not set the logged in user could only edit circulation rules for its the own library (please note that manage_circ_rules is still required)" 4. Apply patch and reload page 5. Text should now display "Edit circulation rules from any library. If not set the logged in user could only edit circulation rules for their own library (please note that manage_circ_rules is still required)" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84084&action=edit Bug 21930: Reworded message on permissions.inc 1. Go to patrons account, more, Set Permissions. 2. Dropdown the Parameters section. 3. Text should display "If not set the logged in user could only edit circulation rules for its the own library (please note that manage_circ_rules is still required)" 4. Apply patch and reload page 5. Text should now display "Edit circulation rules from any library. If not set the logged in user could only edit circulation rules for their own library (please note that manage_circ_rules is still required)" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #4)
Note: I prefer Katrin's wording, but I don't know whether I understand what exactly is required for the wording, except to remove 'the':
"Manage circulation rules from any library. If not set the logged in user can only edit circulation rules from their own library (please note that manage_circ_rules is still required)."
Should 'from' in both occurences be 'for'?
I have made Bug 22149 for this to be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 [Bug 22149] Grammar fix in the manage_circ_rules_from_any_libraries description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21930 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not push to 17.11.x to avoid translation work -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org