https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 --- Comment #1 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84104&action=edit Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- Hi Jasmine. After reviewing this I think it should be 'for' rather than 'from'. Also, the patch doesn't change the text. If you could redo with the new wording as follows: "Manage circulation rules for any library. If not set the logged in user can only edit circulation rules for their own library (please note that manage_circ_rules is still required)." David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84104|0 |1 is obsolete| | --- Comment #3 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84153&action=edit Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84153|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 84171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84171&action=edit Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #9 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22149 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not push to 17.11.x to avoid translation work -- You are receiving this mail because: You are watching all bug changes.