[Bug 16463] New: OPAC discharge page should warn the user about checkouts before they request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Bug ID: 16463 Summary: OPAC discharge page should warn the user about checkouts before they request Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-discharge.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If you have checkouts you cannot request a discharge. The "ask for a discharge" page on the OPAC should warn the user about their checkouts instead of waiting to do so until after they have clicked on the "ask for a discharge" link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |8007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 [Bug 8007] Discharge management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66659&action=edit Bug 16463: Replace discharge link with error message if user has checked out items To test: 1) Ensure the useDischarge syspref is enabled 2) Check out an item to a borrower 3) Log in to the OPAC as this borrower 4) Click the 'ask for a discharge' link in the nav 5) Click the 'Ask for a discharge' link 6) Notice you cannot be discharged because you have checkouts 7) Apply the patch, click the 'ask for a discharge' link in the nav 8) Notice the link has been replaced with an appropriate error message 9) Attempt to force the discharge URL: /cgi-bin/koha/opac-discharge?op=request 10) Notice the message and you cannot be discharged. 11) Confirm that when you check in your item, the discharge link shows again and works as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Signed Off --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66659|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67033&action=edit Bug 16463: Replace discharge link with error message if user has checked out items To test: 1) Ensure the useDischarge syspref is enabled 2) Check out an item to a borrower 3) Log in to the OPAC as this borrower 4) Click the 'ask for a discharge' link in the nav 5) Click the 'Ask for a discharge' link 6) Notice you cannot be discharged because you have checkouts 7) Apply the patch, click the 'ask for a discharge' link in the nav 8) Notice the link has been replaced with an appropriate error message 9) Attempt to force the discharge URL: /cgi-bin/koha/opac-discharge?op=request 10) Notice the message and you cannot be discharged. 11) Confirm that when you check in your item, the discharge link shows again and works as expected. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Caroline, please don't forget to add your sign-off line to the bug. You can find instructions on the wiki: https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off I've added it to this bug for you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And thx for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67033|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67446&action=edit Bug 16463: Replace discharge link with error message if user has checked out items To test: 1) Ensure the useDischarge syspref is enabled 2) Check out an item to a borrower 3) Log in to the OPAC as this borrower 4) Click the 'ask for a discharge' link in the nav 5) Click the 'Ask for a discharge' link 6) Notice you cannot be discharged because you have checkouts 7) Apply the patch, click the 'ask for a discharge' link in the nav 8) Notice the link has been replaced with an appropriate error message 9) Attempt to force the discharge URL: /cgi-bin/koha/opac-discharge?op=request 10) Notice the message and you cannot be discharged. 11) Confirm that when you check in your item, the discharge link shows again and works as expected. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.19 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org