[Bug 19307] New: t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Bug ID: 19307 Summary: t/db_dependent/Circulation/NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We count on getting an issuing impossible, but if this pref enabled we get a needs confirmation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67114&action=edit Bug 19307 - Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |nick@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67114|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 67163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67163&action=edit Bug 19307 - Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Attachment #67163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67114|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Oops, sorry. I signed off this one by error while trying to sign off another bug (new to git, linux and koha, does it show? haha!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67114|0 |1 is obsolete| | --- Comment #4 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67320&action=edit Bug 19307 - Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67320|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67408&action=edit Bug 19307: Mock the AllowFineOverride preference to ensure expected result To test: 1 - Set 'AllowFineOverride' to allow 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 3 - 1 test fails 4 - Apply patch 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 6 - All tests pass 7 - Set 'AllowFineOverride' to 'Don't allow' 8 - Tests should still pass Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.19 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org