[Bug 11752] New: In OPAC, the serials details display the wrong periodicity
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Bug ID: 11752 Summary: In OPAC, the serials details display the wrong periodicity Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org When in opac-detail.pl, for a serial, if you click "more details", the description written there for the periodicity is wrong. opac-serial-issues.tt builds the description all wrong based on the entry in subscription.periodicity, that doesn't match the description in subscripion_frequencies. TESTING - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |francois.charbonnier@inlibr | |o.com Assignee|oleonard@myacpl.org |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 25214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25214&action=edit Bug 11752 - wrong periodicity in OPAC details This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials. TESTING to reproduce - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. In fact any periodicity chosen would display a wrong description, not matching the intranet. After the patch, the display is corrected. As a bonus, the "every 2 years" now has a description, where it had none before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Additional note to the testing procedure: - when in opac-detail.pl, you need to select the second tab, "Subscriptions" in order to see the "More details" link at the bottom. No wonder this very obvious bug was never spotted by anyone... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25214|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25234&action=edit Bug 11752 - wrong periodicity in OPAC details This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials. TESTING to reproduce - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. In fact any periodicity chosen would display a wrong description, not matching the intranet. After the patch, the display is corrected. As a bonus, the "every 2 years" now has a description, where it had none before. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- It seems periodicityX should not be used anymore. You have to use the frequency description. Is the serial/serial-issues.pl a dead script (which refers to periodicityX too)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25234|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25280&action=edit Bug 11752 - wrong periodicity in OPAC details This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials. TESTING to reproduce - create/find a serial with a 1/week periodicity (4 in the database) - Find it in the opac-detail.pl, click "more details" at the bottom - validate the string. Before the patch, it will say: "The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues" The "every 3 weeks" is clearly wrong. In fact any periodicity chosen would display a wrong description, not matching the intranet. After the patch, the display is corrected. As a bonus, the "every 2 years" now has a description, where it had none before. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Waiting for a response to the question/comment on comment 4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 --- Comment #7 from Blou <philippe.blouin@inlibro.com> --- 1) that description is in the database, making its translation ugly if I understand right. 2) this is a patch to a very obvious problem only one user ever noticed. We patched it while minimizing the effort needed (qa and dev). Rearchitecturing the way the information goes to the .tt does not fit the community need IMO (since no one ever made those mouse clicks, seemingly). I can see the benefit long term, if someone has something else to fix in that area. At this point, we don't. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch fixes default values (from the installer or updatedb). If values are redefined, the display will be broken too. An easy way will be to retrieve frequencies.description, but it won't be translatable. Since it improves the current behavior, I agree to pass QA on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Blou from comment #7)
1) that description is in the database, making its translation ugly if I understand right. 2) this is a patch to a very obvious problem only one user ever noticed.
Only one of /your/ users, perhaps.
We patched it while minimizing the effort needed (qa and dev). Rearchitecturing the way the information goes to the .tt does not fit the community need IMO (since no one ever made those mouse clicks, seemingly).
It is perhaps something to be cautious about to make assertions about community needs. I will instead make a concrete point: your patch, while it is an improvement over the current state of affairs, does not account for the fact that nowadays users can readily create additional frequencies. Consequently, the OPAC serials details page *will* require more work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Philippe! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- See also bug 12108. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12108 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11752 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org