[Bug 11955] New: Remove spaces in empty indicators after linking an authority to a biblio record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Bug ID: 11955 Summary: Remove spaces in empty indicators after linking an authority to a biblio record. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 26438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26438&action=edit Remove spaces in empty indicators when linking an authority to a biblio record. This patch removes spaces in indicators which are imported when we link an authority to a biblio record. The spaces made the indicators harder to edit after the linking, because we had to delete the superfluous space character before a new value could be entered. Test case : * Create of modify a biblio. * Click on the "Tag editor" button for one of the authority field of the biblio. * Search for an existing authority and import it. The selected authority should have a least one empty indicator. * Once the authority is imported into the biblio record, click on the empty indicator field. You should be able to enter a new value without having to delete an unwanted space character. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 11697 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26438|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27066&action=edit [SIGNED-OFF] Remove spaces in empty indicators when linking an authority to a biblio record. http://bugs.koha-community.org/show_bug.cgi?id=11955 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> To test: 1. Open some authority on editor, save with empty indicators. They are saved as ind1=" " ind2=" " on auth_header tables, with spaces 2. Edit some record, link some tag with previous auth, indicators now have a space on it (or ind1 at last) 3. Apply the patch 4. repeat 2, space is gone Work as described. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27066|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 27227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27227&action=edit Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. This patch removes spaces in indicators which are imported when we link an authority to a biblio record. The spaces made the indicators harder to edit after the linking, because we had to delete the superfluous space character before a new value could be entered. To test: 1. Open some authority on editor, save with empty indicators. They are saved as ind1=" " ind2=" " on auth_header tables, with spaces 2. Edit some record, link some tag with previous auth, indicators now have a space on it (or ind1 at last) 3. Apply the patch 4. repeat 2, space is gone Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fcapovilla@live.ca QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Frédérick! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11955 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org