[Bug 40117] New: Add option for modification of not for loan from items tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Bug ID: 40117 Summary: Add option for modification of not for loan from items tab Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Not for loan is a powerful status with a lot of flexibility for libraries, especially since it has the -/+ holdable but not circulating/does not circulate capability. And many libraries are not using it to full advantage because the only way to edit it is from the edit item form, not easily accessible from the items page (moredetail.pl) like other statuses. It would be nice if, perhaps by system preference, a library could optionally make editing of the not for loan status available from moredetail.pl. That way libraries that want NFL status updating a bit more locked down can still only access it from editing an item, and libraries that want staff to be able to use more flexible statuses make it more accessible to staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Currently, the values on the items tab can be edited by anyone with basic circulation permissions. If we show Not For Loan on this page, would it be editable at the same permission level? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #2 from hebah@bywatersolutions.com --- I would think yes, that's a logical correlation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org --- Comment #3 from Angela Berrett <angela.berrett@familysearch.org> --- This would be nice for records that have a lot of items and you only want to change a couple, but to different statuses. It can be done on the Items tab instead of loading all items when choosing Edit from the Normal screen and everything has to load in another screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 crosenthal@pwcgov.org <crosenthal@pwcgov.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crosenthal@pwcgov.org --- Comment #4 from crosenthal@pwcgov.org <crosenthal@pwcgov.org> --- +! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205670&action=edit Bug 40117: UPdate moredetail.pl and updateitem.pl to recognize notforloan Patch from commit eb70c3f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205671&action=edit Bug 40117: Update the template To test: 1. APPLY PATCH and restart_all 2. Find or create a record and click on the 'Items' tab ( moredetail.tt ) 3. Each item, under Statuses, should now have a Not for loan status: dropdown 4. Open the dropdown and check the not for loan value, making sure they all appear. 5. Change some not for loan statuses and make sure they apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to hebah from comment #0)
Not for loan is a powerful status with a lot of flexibility for libraries, especially since it has the -/+ holdable but not circulating/does not circulate capability. And many libraries are not using it to full advantage because the only way to edit it is from the edit item form, not easily accessible from the items page (moredetail.pl) like other statuses.
It would be nice if, perhaps by system preference, a library could optionally make editing of the not for loan status available from moredetail.pl. That way libraries that want NFL status updating a bit more locked down can still only access it from editing an item, and libraries that want staff to be able to use more flexible statuses make it more accessible to staff.
I just added these as lost, withdrawn, damaged are already implemented. NO system pref. Maybe adding 1 system pref that allows you to control which of the 4 dropdowns should display here? ( lost, withdrawn, damaged, notforloan ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from John Vinke <jvinke@austinseminary.edu> --- This appears to work for the default NOT_LOAN values, but not new ones. I created two new NOT_LOAN values, including one with a library limitation. They displayed correctly as options, but I could not apply the custom NOT_LOAN value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205670|0 |1 is obsolete| | Attachment #205671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #9 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206199&action=edit Bug 40117: UPdate moredetail.pl and updateitem.pl to recognize notforloan Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #10 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206200&action=edit Bug 40117: Update the template To test: 1. APPLY PATCH and restart_all 2. Find or create a record and click on the 'Items' tab ( moredetail.tt ) 3. Each item, under Statuses, should now have a Not for loan status: dropdown 4. Open the dropdown and check the not for loan value, making sure they all appear. 5. Change some not for loan statuses and make sure they apply. Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvinke@austinseminary.edu --- Comment #11 from John Vinke <jvinke@austinseminary.edu> --- I think I erroneously added that sign off. I intended to write Failed QA. Something about this doesn't appear to work with the non-default NOT_LOAN values. I retested this again, this time without a library limitation on the NOT_LOAN reason. 1. Applied patch and ran restart_all 2. Performed test with a Koha default NOT_LOAN reason. (I used staff collection) 3. Created a new NOT_LOAN reason. (SMELLS - Book is airing out.) 4. Attempted to set the NOT_LOAN reason from Staff Collection to SMELLS. 5. Viewed item record and NOT_LOAN value was cleared. Had neither the previous value or the new value. 6. I repeated this attempt on another item and it also did not apply the new NOT_LOAN reason. If it's possible that there is another step I should do after adding a custom NOT_LOAN value, please let me know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from John Vinke <jvinke@austinseminary.edu> --- The issue I reported earlier was that I was using non-numeric authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206199|0 |1 is obsolete| | Attachment #206200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #13 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206556&action=edit Bug 40117: UPdate moredetail.pl and updateitem.pl to recognize notforloan Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #14 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206557&action=edit Bug 40117: Update the template To test: 1. APPLY PATCH and restart_all 2. Find or create a record and click on the 'Items' tab ( moredetail.tt ) 3. Each item, under Statuses, should now have a Not for loan status: dropdown 4. Open the dropdown and check the not for loan value, making sure they all appear. 5. Change some not for loan statuses and make sure they apply. Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to John Vinke from comment #14)
Created attachment 206557 [details] [review] Bug 40117: Update the template
To test: 1. APPLY PATCH and restart_all 2. Find or create a record and click on the 'Items' tab ( moredetail.tt ) 3. Each item, under Statuses, should now have a Not for loan status: dropdown 4. Open the dropdown and check the not for loan value, making sure they all appear. 5. Change some not for loan statuses and make sure they apply.
Signed-off-by: John Vinke <jvinke@austinseminary.edu>
(In reply to John Vinke from comment #12)
The issue I reported earlier was that I was using non-numeric authorized values.
Good catch, here are some relevant bugs to that: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27512 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40117 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24288 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org