[Bug 41063] New: Additional fields are broken in Vue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Bug ID: 41063 Summary: Additional fields are broken in Vue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@openfifth.co.uk, martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, pedro.amorim@openfifth.co.uk To reproduce: 1) Go to Administration > Additional fields and add an additional field for erm_agreements 2) Enable ERM and navigate to ERM > Agreements 3) Click to add a new agreement and then fill out the form, making sure to add something into your new additional field 4) Hit save and navigate to the agreement you have just added 5) There will be no additional field added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188212&action=edit Bug 41063: Fix additional fields in Vue Test plan: 1) Go to Administration > Additional fields and add an additional field for erm_agreements 2) Enable ERM and navigate to ERM > Agreements 3) Click to add a new agreement and then fill out the form, making sure to add something into your new additional field 4) Hit save and navigate to the agreement you have just added 5) There will be no additional field added 6) Apply patch and yarn js:build 7) Repeat steps 3 - 5 8) The additional field should be added and displayed correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40192 [Bug 40192] Add additional fields to ERM titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 [Bug 38262] Add additional fields to Vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40192 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40192 [Bug 40192] Add additional fields to ERM titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188216&action=edit Bug 41063: Allow setting of a group for additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188216|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188228&action=edit Bug 41063: Allow setting of a group for additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188228|0 |1 is obsolete| | --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 188363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188363&action=edit Bug 41063: Allow setting of a group for additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188212|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 188389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188389&action=edit Bug 41063: Fix additional fields in Vue Test plan: 1) Go to Administration > Additional fields and add an additional field for erm_agreements 2) Enable ERM and navigate to ERM > Agreements 3) Click to add a new agreement and then fill out the form, making sure to add something into your new additional field 4) Hit save and navigate to the agreement you have just added 5) There will be no additional field added 6) Apply patch and yarn js:build 7) Repeat steps 3 - 5 8) The additional field should be added and displayed correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188363|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 188390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188390&action=edit Bug 41063: Allow setting of a group for additional fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the saving of release notes| |data for additional fields | |for modules in Koha that | |use Vue (ERM, Preservation, | |Acquisitions). The data | |entered for additional | |fields is now saved, | |instead of being ignored | |and lost. For example, data | |for additional fields added | |to ERM agreements was not | |being saved, but now are. --- Comment #7 from David Nind <david@davidnind.com> --- I changed the status to major (from enhancement) and added a release note. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Additional fields are |Additional fields are |broken in Vue |broken in Vue (values | |entered are not saved) Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I followed the test plan and tried restarting services, but my additional field never showed up and wasn't saved in my agreement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- It still works for me when applying on main - you might need a hard refresh of the browser to rule out caching of the pre-existing javascript if you didn't try that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|aleisha@catalyst.net.nz |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188389|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188752&action=edit Bug 41063: Fix additional fields in Vue Additional fields added through Vue.js resource forms were not being saved to the database. This was caused by using ref() instead of reactive() for the current_additional_fields_values object. Since ref() only provides shallow reactivity for objects, changes to nested properties were not being tracked properly. This switches to reactive() which provides deep reactivity tracking, ensuring that all changes to additional field values are properly captured and submitted when the form is saved. Test plan: 1) Go to Administration > Additional fields and add an additional field for erm_agreements 2) Enable ERM and navigate to ERM > Agreements 3) Click to add a new agreement and then fill out the form, making sure to add something into your new additional field 4) Hit save and navigate to the agreement you have just added 5) There will be no additional field added 6) Apply patch and yarn js:build 7) Repeat steps 3 - 5 8) The additional field should be added and displayed correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188390|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188753&action=edit Bug 41063: Allow setting of a group for additional fields Adds support for the extendedAttributesFieldGroup configuration option in base-resource.js composable. This allows developers to specify which form section/group additional fields should appear in, providing better control over form organization and UX. Without this, additional fields always appeared in the default group, making it difficult to logically organize complex forms with multiple field groupings. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I tested with all additional field types available and all worked as expected for me.. I couldn't replicate Aliesha's issues. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Bug 41063 depends on bug 38201, which changed state. Bug 38201 Summary: VueJS architecture rethink https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This will not be backported to 25.05.x. I’d be happy to take another look if you believe this is incorrect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #15 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org