[Bug 39075] New: Fix DB inconsistencies in the usage statistics module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Bug ID: 39075 Summary: Fix DB inconsistencies in the usage statistics module Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Highlighted here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587#c38 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 177674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177674&action=edit Bug 39075: Fix DB inconsistencies This patch fixes DB inconsistencies introduced in bug 34587 Test plan: 1) Run 'updatedatabase' 2) There should be no errors 3) Check the database and observe the correct assignment of the following columns - erm_counter_logs.importdate - erm_counter_files.date_uploaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177674|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177727&action=edit Bug 39075: Fix DB inconsistencies This patch fixes DB inconsistencies introduced in bug 34587 Test plan: 1) Run 'updatedatabase' 2) There should be no errors 3) Check the database and observe the correct assignment of the following columns - erm_counter_logs.importdate - erm_counter_files.date_uploaded Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] chmod 755 on new dbrev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177728&action=edit Bug 39075: (QA follow-up) Use new bug number. refer to old Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks Matt. Trivial. SO and QA in one pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 [Bug 34587] Add a Usage Statistics module to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pondering if this is an enh or a bugfix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- https://jenkins.koha-community.org/job/Koha_Main_MariaDB_update/78/console 16:08:12 koha_1 | +++ b/Koha/Schema/Result/ErmCounterFile.pm 16:08:12 koha_1 | @@ -67,7 +67,7 @@ content of the counter file 16:08:12 koha_1 | data_type: 'timestamp' 16:08:12 koha_1 | datetime_undef_if_invalid: 1 16:08:12 koha_1 | default_value: current_timestamp 16:08:12 koha_1 | - is_nullable: 1 16:08:12 koha_1 | + is_nullable: 0 16:08:12 koha_1 | 16:08:12 koha_1 | counter file upload date 16:08:12 koha_1 | 16:08:12 koha_1 | @@ -89,7 +89,7 @@ __PACKAGE__->add_columns( 16:08:12 koha_1 | data_type => "timestamp", 16:08:12 koha_1 | datetime_undef_if_invalid => 1, 16:08:12 koha_1 | default_value => \"current_timestamp", 16:08:12 koha_1 | - is_nullable => 1, 16:08:12 koha_1 | + is_nullable => 0, The db rev is missing the NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Still valid, we need it for 25.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181909&action=edit Bug 39075: Explicit NOT NULL for timestamp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Created attachment 181909 [details] [review] Bug 39075: Explicit NOT NULL for timestamp
To fix Koha_Main_MariaDB_update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_25_05_candidate | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Created attachment 181909 [details] [review] Bug 39075: Explicit NOT NULL for timestamp
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39075 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon@openfifth.co | |.uk Status|Needs documenting |RESOLVED --- Comment #14 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No updates to the Koha Manual needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org