[Bug 43086] New: Prefill unauthenticated patron information for new ILL requests if available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Bug ID: 43086 Summary: Prefill unauthenticated patron information for new ILL requests if available Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: olivia.reynolds@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com Target Milestone: --- If an unauthenticated patron makes multiple ILL requests back-to-back, they have to fill in their patron details every time. Saving and prefilling these details would save time in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Comma delimited| |NHS England list of Sponsors| | Status|NEW |Needs Signoff Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #1 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 202006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202006&action=edit Bug 43086: Prefill unauthenticated ILL request patron information This patch uses the browser's sessionStorage to save the unauthenticated patron information from ILL request creation. This saves users time if they wish to make multiple requests. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Make any valid request, noting the name, email address, and chosen library used. 5. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 6. Choose the "Standard" provider for the new ILL request. 7. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 8. Change the name to a different value. 9. Change the type of request, causing a page load. 10. Verify the changed name is retained, rather than prefilling an incorrect one. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 203393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203393&action=edit Bug 43086: Prefill unauthenticated ILL request patron information This patch uses the browser's sessionStorage to save the unauthenticated patron information from ILL request creation. This saves users time if they wish to make multiple requests. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Make any valid request, noting the name, email address, and chosen library used. 5. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 6. Choose the "Standard" provider for the new ILL request. 7. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 8. Change the name to a different value. 9. Change the type of request, causing a page load. 10. Verify the changed name is retained, rather than prefilling an incorrect one. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 203628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203628&action=edit Bug 43086: Prefill unauthenticated ILL request patron information This patch uses the browser's sessionStorage to save the unauthenticated patron information from ILL request creation. This saves users time if they wish to make multiple requests. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Make any valid request, noting the name, email address, and chosen library used. 5. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 6. Choose the "Standard" provider for the new ILL request. 7. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 8. Change the name to a different value. 9. Change the type of request, causing a page load. 10. Verify the changed name is retained, rather than prefilling an incorrect one. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Olivia, seeing this one assigned to me by our awesome QAM, I was a bit worried if I would remember how to test the unauthenticated requests, so thank you for the great test plan :) I understand the use case and that it could be quite helpful to users, but I wonder about the implications if this was used on a publicly available computer in the library. I am pondering if storing the patron's name and email plain text in the user's session is the best way to go here or if there could be data privacy issues, especially if the computer used was a public one. Maybe it could be remedied by a "remember me" checkbox or similar so it was an opt-in thing? We could also add a hint about not using it in a public environment. There is also no way to make it forget your credentials apart from closing the browser, (which people might not be aware of) if I understand this correctly. I am adding a sign-off for it working as intended an David Cook for another opinion on implementation. Another finding for a new bug, but maybe interesting for this use case as well: Once I have added my first request, I am stuck on the confirmation screen. A button to "place another request" might be helpful here. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #5 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Thanks for taking a look Katrin, and glad the test plan was useful. There's still so much of Koha I have no idea about so I try to make them very step-by-step. Truthfully, I hadn't considered that the unauthenticated OPAC could be used on a shared session. In that case, I agree that we should avoid remembering user details by default. I'll get in touch with the sponsor and see what they think about that issue, if they'd be happy to make it opt-in, or whether we could do a system preference for this. Otherwise, this feature may best belong in a plugin. Looking at the OPAC form, none of these fields seem to be marked as `autocomplete="off"`, so I think the browser could save their values automatically and present them to future users. It might be worth disabling autocomplete on them whilst we're looking at this area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Olivia Reynolds from comment #5)
Truthfully, I hadn't considered that the unauthenticated OPAC could be used on a shared session. In that case, I agree that we should avoid remembering user details by default. I'll get in touch with the sponsor and see what they think about that issue, if they'd be happy to make it opt-in, or whether we could do a system preference for this. Otherwise, this feature may best belong in a plugin.
+1 Sounds great! I'll move this to "Failed QA" meanwhile as we don't have something better to indicate it might need a bit more thought/work.
Looking at the OPAC form, none of these fields seem to be marked as `autocomplete="off"`, so I think the browser could save their values automatically and present them to future users. It might be worth disabling autocomplete on them whilst we're looking at this area.
I like this idea and it feels like the right thing to do. I am only a little worried the library requesting this might rely on it right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- After talking with the sponsor, they're happy to have an opt-in checkbox for saving the unauthenticated patron details. I've submitted a patch to add that to the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #8 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 204169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204169&action=edit Bug 43086: (follow-up) Require checkbox consent to save details There are reasonable privacy concerns around automatically saving unauthenticated user details. If the OPAC is used on a shared machine, future users can recover the information provided by past users. This patch adds a "remember me" checkbox to the unauthenticated ILL request form. If it is checked upon submit, the details are saved. If it isn't checked, all existing stored details are deleted. The checkbox is unchecked by default unless there is existing saved data. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Verify the "remember me" checkbox is unchecked at the bottom of the form. 5. Check the "Remember me" checkbox. 6. Make any valid request, noting the name, email address, and chosen library used. 7. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 8. Choose the "Standard" provider for the new ILL request. 9. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 10. Verify the "remember me" checkbox is checked. 11. Uncheck the "remember me" checkbox. 12. Make another valid request. 13. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 14. Choose the "Standard" provider for the new ILL request. 15. Verify no data is prefilled, and that the "remember me" checkbox is unchecked. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #9 from David Nind <david@davidnind.com> --- As soon as I select the "Type", for example Book or Chapter, then the "Remember me" checkbox is no longer selected. "Remember me" checkbox clears when you choose "Type": 1. Complete patron options 2. At the bottom of the page select "Remember me" 3. Select the "Type", for example "Book" 4. Note that the "Remember me" check box is cleared If you complete the request form and select the "Remember me" checkbox as the last step, then your details are remembered for the next request - as well as the "Remember me" checkbox being text. However, once you choose the type, the "Remember me" checkbox is cleared. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Thanks for the testing and for spotting that bug, David. I've amended the follow-up patch to maintain the checkbox state across type choice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #11 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 208456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208456&action=edit Bug 43086: (follow-up) Require checkbox consent to save details There are reasonable privacy concerns around automatically saving unauthenticated user details. If the OPAC is used on a shared machine, future users can recover the information provided by past users. This patch adds a "remember me" checkbox to the unauthenticated ILL request form. If it is checked upon submit, the details are saved. If it isn't checked, all existing stored details are deleted. The checkbox is unchecked by default unless there is existing saved data. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Verify the "remember me" checkbox is unchecked at the bottom of the form. 5. Before choosing a request type, check the "Remember me" checkbox. 6. Choose the request type. 7. Verify the "Remember Me" checkbox is still checked after the page reloads. 7. Make any valid request, noting the name, email address, and chosen library used. 8. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 9. Choose the "Standard" provider for the new ILL request. 10. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 11. Verify the "remember me" checkbox is checked. 12. Uncheck the "remember me" checkbox. 13. Make another valid request. 14. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 15. Choose the "Standard" provider for the new ILL request. 16. Verify no data is prefilled, and that the "remember me" checkbox is unchecked. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203628|0 |1 is obsolete| | Attachment #208456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 208512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208512&action=edit Bug 43086: Prefill unauthenticated ILL request patron information This patch uses the browser's sessionStorage to save the unauthenticated patron information from ILL request creation. This saves users time if they wish to make multiple requests. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Make any valid request, noting the name, email address, and chosen library used. 5. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 6. Choose the "Standard" provider for the new ILL request. 7. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 8. Change the name to a different value. 9. Change the type of request, causing a page load. 10. Verify the changed name is retained, rather than prefilling an incorrect one. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 208513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208513&action=edit Bug 43086: (follow-up) Require checkbox consent to save details There are reasonable privacy concerns around automatically saving unauthenticated user details. If the OPAC is used on a shared machine, future users can recover the information provided by past users. This patch adds a "remember me" checkbox to the unauthenticated ILL request form. If it is checked upon submit, the details are saved. If it isn't checked, all existing stored details are deleted. The checkbox is unchecked by default unless there is existing saved data. Test plan: 1. Enable the system preferences "ILLModule" and "ILLOpacUnauthenticatedRequest". 2. In a logged-out OPAC window, navigate to /cgi-bin/koha/opac-illrequests.pl?op=create 3. Choose the "Standard" provider for the new ILL request. 4. Verify the "remember me" checkbox is unchecked at the bottom of the form. 5. Before choosing a request type, check the "Remember me" checkbox. 6. Choose the request type. 7. Verify the "Remember Me" checkbox is still checked after the page reloads. 7. Make any valid request, noting the name, email address, and chosen library used. 8. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 9. Choose the "Standard" provider for the new ILL request. 10. Verify that the name, email address, and chosen library are automatically filled with the same values used before. 11. Verify the "remember me" checkbox is checked. 12. Uncheck the "remember me" checkbox. 13. Make another valid request. 14. In the same OPAC session, navigate again to /cgi-bin/koha/opac-illrequests.pl?op=create 15. Choose the "Standard" provider for the new ILL request. 16. Verify no data is prefilled, and that the "remember me" checkbox is unchecked. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |"Remember me" checkbox to | |the unauthenticated ILL | |request form for the OPAC. | |If it is checked upon | |submit, the details are | |remembered. | | | |Rationale: If an | |unauthenticated patron | |makes multiple ILL requests | |back-to-back, they have to | |fill in their patron | |details every time. | |Remembering and prefilling | |these details will save | |time and improve the patron | |experience. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org