[Bug 29571] New: Mainpage : "All librairies" pending suggestions are visible only if the current library has suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Bug ID: 29571 Summary: Mainpage : "All librairies" pending suggestions are visible only if the current library has suggestions Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: christophe.torin@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org On the mainpage, the "Suggestions pending approval" block is shown only if there are suggestions for the user's current library, even if the other library have suggestions. Example with 3 libraries : , LIB_A (3 suggestions), LIB_B (1 sugg.), LIB_C (0 sugg.) LIB_A will show "Suggestions pending approval: LIB_A: 3 / All Libraries: 4" LIB_B will show "Suggestions pending approval: LIB_B: 1 / All Libraries: 4" LIB_C will show nothing. If this is to be fixed, it would be simple, in the template intranet-main.tt on line 178 : The condition on "pendingsuggestions" will return false if it's equal to 0, thus hiding the whole block, even if the field "all_pendingsuggestions" is set and above 0. This was seen on koha 20.11, but I checked and is still on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mainpage : "All librairies" |Mainpage : "All libraries" |pending suggestions are |pending suggestions are |visible only if the current |visible only if the current |library has suggestions |library has suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128010&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com CC| |jonathan.druart+koha@gmail. | |com Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128010|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 128060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128060&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |pending suggestions in the | |staff interface so that it | |now shows pending | |suggestions for all | |libraries, for example: | |"Suggestions pending | |approval: Centerville: 0 / | |All libraries: 1.". | |Previously suggestions | |pending approval was only | |shown if there were | |suggestions for the user's | |current library. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Christophe TORIN <christophe.torin@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Christophe TORIN <christophe.torin@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128060|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128271&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: ThibaudGLT <thibaud.guillot@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 29628 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128271|0 |1 is obsolete| | --- Comment #5 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 128399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128399&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: ThibaudGLT <thibaud.guillot@biblibre.com> Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr --- Comment #6 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Christophe TORIN from comment #0)
On the mainpage, the "Suggestions pending approval" block is shown only if there are suggestions for the user's current library, even if the other library have suggestions. The suggestions pending approval are also meant to be displayed in the right hand side of Home > Acquisitions. The change Jonathan suggested can be applied to koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt as well.
Would it be OK if I submitted a follow-up patch for this here, and also change the Bug title accordingly (remove "Mainpage : ")? Or is it best practice to submit a new bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi Andreas, attach a patch here and switch the status back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #8 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 128426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128426&action=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #9 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Jonathan Druart from comment #7)
Hi Andreas, attach a patch here and switch the status back to Needs Signoff. Thanks, Jonathan. Follow-up attached and bug status changed.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128426|0 |1 is obsolete| | --- Comment #10 from Florian <florian.bontemps@biblibre.com> --- Created attachment 128473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128473&action=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128399|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128710&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: ThibaudGLT <thibaud.guillot@biblibre.com> Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128473|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128711&action=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |25033 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 [Bug 25033] Counts of suggestions are confusing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org