https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25029 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128081&action=edit Bug 29591: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Will try to QA very soon. Thx -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29695 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that I am suggesting to remove borrowers.json on bug 29695. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128081|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 128558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128558&action=edit Bug 29591: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29695 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #5)

(In reply to Jonathan Druart from comment #3)

...

Note that I am suggesting to remove borrowers.json on bug 29695.

Thats great. But no reason to skip this patch. This works and can be backported as well.

Of course, it was just something I wanted to highlight here. I have rebased the patches on top of this one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 [Bug 29695] Centralize columns' descriptions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.